linux-kernel - Re: [PATCH v5whatever, now with typechecking] vsprintf: %pf(%p)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220628174124.uyuyi4wytowwfjdl@moria.home.lan>
Date:   Tue, 28 Jun 2022 13:41:24 -0400
From:   Kent Overstreet <kent.overstreet@...il.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Petr Mladek <pmladek@...e.com>
Subject: Re: [PATCH v5whatever, now with typechecking] vsprintf: %pf(%p)

On Tue, Jun 28, 2022 at 10:29:05AM -0700, Linus Torvalds wrote:
> On Tue, Jun 28, 2022 at 10:23 AM Kent Overstreet
> <kent.overstreet@...il.com> wrote:
> >
> >  - We need to be able to specify the pretty-printer function, and not just have
> >    one per type
> 
> I even showed you how toi do that, you just deleted it.
> 
> Anyway, I'm done with this discussion. I think this is all pointless.
> I think you are making things worse, you are making things more
> complex, and I don't think this is a direction we want to take things
> in.

Linus, I'm ok with this not working out. Really. Trying to do something
difficult and new _often_ ends up in the result being too complicated and ugly
to live.

But that doesn't mean I'm not going to try, and if it's an idea I think has
potential I'll keep trying because it often takes a couple attempts and a couple
rewrites.

Anyways, I've been listening to your feedback (and honestly pretty appreciative
of it, it beats the hell out of what I was getting on the list). I'm sorry if
you feel like I wasn't listening or taking into account _everything_ you had to
say, this is a problem I've been thinking about for quite some time and I've got
a number of constraints I'm trying to fit.

And I apologize, it looks like I did miss something - I went back and reread and
saw you also had pretty_fn() in your example. So sorry for skipping past that,
my bad.