lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Jun 2022 18:57:23 +0100 From: Al Viro <viro@...iv.linux.org.uk> To: Ian Kent <raven@...maw.net> Cc: Andrew Morton <akpm@...ux-foundation.org>, Siddhesh Poyarekar <siddhesh@...plt.org>, David Howells <dhowells@...hat.com>, Miklos Szeredi <miklos@...redi.hu>, Carlos Maiolino <cmaiolino@...hat.com>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/2] vfs: escape hash as well On Tue, Jun 28, 2022 at 08:30:58AM +0800, Ian Kent wrote: > From: Siddhesh Poyarekar <siddhesh@...plt.org> > > When a filesystem is mounted with a name that starts with a #: > > # mount '#name' /mnt/bad -t tmpfs > > this will cause the entry to look like this (leading space added so > that git does not strip it out): > > #name /mnt/bad tmpfs rw,seclabel,relatime,inode64 0 0 > > This breaks getmntent and any code that aims to parse fstab as well as > /proc/mounts with the same logic since they need to strip leading spaces > or skip over comment lines, due to which they report incorrect output or > skip over the line respectively. > > Solve this by translating the hash character into its octal encoding > equivalent so that applications can decode the name correctly. > > Signed-off-by: Siddhesh Poyarekar <siddhesh@...plt.org> > Signed-off-by: Ian Kent <raven@...maw.net> ACK; I'll grab that one (in #work.misc - I don't believe it's #fixes fodder).
Powered by blists - more mailing lists