linux-kernel - Re: [RESEND V9,1/7] dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20220628210716.GA963202-robh@kernel.org>
Date:   Tue, 28 Jun 2022 15:07:16 -0600
From:   Rob Herring <robh@...nel.org>
To:     "kyrie.wu" <kyrie.wu@...iatek.com>
Cc:     Irui Wang <irui.wang@...iatek.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Tzung-Bi Shih <tzungbi@...omium.org>,
        angelogioacchino.delregno@...labora.com,
        nicolas.dufresne@...labora.com, wenst@...omium.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Tomasz Figa <tfiga@...omium.org>, xia.jiang@...iatek.com,
        maoguang.meng@...iatek.com, srv_heupstream@...iatek.com
Subject: Re: [RESEND V9,1/7] dt-bindings: mediatek: Add mediatek,
 mt8195-jpgenc compatible

On Mon, Jun 20, 2022 at 02:04:38PM +0800, kyrie.wu wrote:
> On Fri, 2022-06-17 at 17:11 -0600, Rob Herring wrote:
> > On Tue, Jun 14, 2022 at 08:10:18PM +0800, Irui Wang wrote:
> > > From: kyrie wu <kyrie.wu@...iatek.com>
> > > 
> > > Add mediatek,mt8195-jpgenc compatible to binding document.
> > > 
> > > Signed-off-by: kyrie wu <kyrie.wu@...iatek.com>
> > > ---
> > >  .../media/mediatek,mt8195-jpegenc.yaml        | 153
> > > ++++++++++++++++++
> > >  1 file changed, 153 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/media/mediatek,mt8195-
> > > jpegenc.yaml
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > > jpegenc.yaml
> > > b/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > > jpegenc.yaml
> > > new file mode 100644
> > > index 000000000000..a7f9f723d5db
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > > jpegenc.yaml
> > > @@ -0,0 +1,153 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: 
> > > http://devicetree.org/schemas/media/mediatek,mt8195-jpegenc.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: MediaTek JPEG Encoder Device Tree Bindings
> > > +
> > > +maintainers:
> > > +  - kyrie wu <kyrie.wu@...iatek.corp-partner.google.com>
> > > +
> > > +description: |-
> > > +  MediaTek JPEG Encoder is the JPEG encode hardware present in
> > > MediaTek SoCs
> > > +
> > > +properties:
> > > +  compatible:
> > > +    items:
> > > +      - const: mediatek,mt8195-jpgenc
> > > +
> > > +  mediatek,jpegenc-multi-core:
> > > +    type: boolean
> > > +    description: |
> > > +      Indicates whether the jpeg encoder has multiple cores or
> > > not.
> > > +
> > > +  power-domains:
> > > +    maxItems: 1
> > > +
> > > +  iommus:
> > > +    maxItems: 4
> > > +    description: |
> > > +      Points to the respective IOMMU block with master port as
> > > argument, see
> > > +      Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> > > for details.
> > > +      Ports are according to the HW.
> > > +
> > > +  "#address-cells":
> > > +    const: 2
> > > +
> > > +  "#size-cells":
> > > +    const: 2
> > > +
> > > +  ranges: true
> > > +
> > > +# Required child node:
> > > +patternProperties:
> > > +  "^jpgenc@[0-9a-f]+$":
> > > +    type: object
> > > +    description: |
> > > +      The jpeg encoder hardware device node which should be added
> > > as subnodes to
> > > +      the main jpeg node.
> > > +
> > > +    properties:
> > > +      compatible:
> > > +        const: mediatek,mt8195-jpgenc-hw
> > > +
> > > +      reg:
> > > +        maxItems: 1
> > > +
> > > +      hw_id:
> > > +        description: |
> > > +          Current jpegenc hw id.
> > 
> > Same question here. Surely, I asked sometime in the last 8 versions,
> > but 
> > no explanation here and I'm not going to go look for it.
> Dear Rob,
> I'm sorry for not giving an accurate explanation in time.
> The MT8195 has own two encoding hardwares, we use hw_id to 
> represent them.
> hw_id = 0, for hardware 0, and hw_id = 1, repesents another one.
> I will improve the description in the next version.

Why do you care which one is which? 

We generally don't do instance indices in DT, so figure out how not to 
need this.

Rob