linux-kernel - Re: [PATCH] platform/x86: hp-wmi: Ignore Sanitization Mode event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b11094eb-fd3c-06d9-adca-7d56f40e7f4f@redhat.com>
Date:   Tue, 28 Jun 2022 23:24:58 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>, markgross@...nel.org
Cc:     Jorge Lopez <jorge.lopez2@...com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: hp-wmi: Ignore Sanitization Mode event

Hi,

On 6/28/22 14:37, Kai-Heng Feng wrote:
> After system resume the hp-wmi driver may complain:
> [ 702.620180] hp_wmi: Unknown event_id - 23 - 0x0
> 
> According to HP it means 'Sanitization Mode' and it's harmless to just
> ignore the event.
> 
> Cc: Jorge Lopez <jorge.lopez2@...com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
>  drivers/platform/x86/hp-wmi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
> index 0d8cb22e30df9..bc7020e9df9e8 100644
> --- a/drivers/platform/x86/hp-wmi.c
> +++ b/drivers/platform/x86/hp-wmi.c
> @@ -89,6 +89,7 @@ enum hp_wmi_event_ids {
>  	HPWMI_BACKLIT_KB_BRIGHTNESS	= 0x0D,
>  	HPWMI_PEAKSHIFT_PERIOD		= 0x0F,
>  	HPWMI_BATTERY_CHARGE_PERIOD	= 0x10,
> +	HPWMI_SANITIZATION_MODE		= 0x17,
>  };
>  
>  /*
> @@ -853,6 +854,8 @@ static void hp_wmi_notify(u32 value, void *context)
>  		break;
>  	case HPWMI_BATTERY_CHARGE_PERIOD:
>  		break;
> +	case HPWMI_SANITIZATION_MODE:
> +		break;
>  	default:
>  		pr_info("Unknown event_id - %d - 0x%x\n", event_id, event_data);
>  		break;