linux-kernel - Re: [PATCH v2 1/2] iio: proximity: sx_common: Don't use IIO device for properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Jun 2022 01:00:53 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Gwendal Grignou <gwendal@...omium.org>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v2 1/2] iio: proximity: sx_common: Don't use IIO device
 for properties

On Wed, Jun 15, 2022 at 02:47:45PM +0300, Andy Shevchenko wrote:
> It's not correct to use artificial device created by IIO core to
> retrieve device properties. Even ->get_default_reg() callback
> takes a simple struct device pointer which suggests it wants to
> operate on the real device.
> 
> Correct this by replacing pointer to IIO device by a real device
> pointer in the caller of ->get_default_reg().

Gwendal, any comments on this version?

-- 
With Best Regards,
Andy Shevchenko