linux-kernel - Re: [PATCH] nfsd: remove redundant assignment to variable len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <75A2391D-B69B-4078-84F9-FB499A0A29B1@oracle.com>
Date:   Tue, 28 Jun 2022 22:14:56 +0000
From:   Chuck Lever III <chuck.lever@...cle.com>
To:     Colin Ian King <colin.i.king@...il.com>
CC:     Jeff Layton <jlayton@...nel.org>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nfsd: remove redundant assignment to variable len



> On Jun 28, 2022, at 5:25 PM, Colin Ian King <colin.i.king@...il.com> wrote:
> 
> Variable len is being assigned a value zero and this is never
> read, it is being re-assigned later. The assignment is redundant
> and can be removed.
> 
> Cleans up clang scan-build warning:
> fs/nfsd/nfsctl.c:636:2: warning: Value stored to 'len' is never read
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Thanks, applied to the NFSD for-next branch.


> ---
> fs/nfsd/nfsctl.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 0621c2faf242..66c352bf61b1 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -633,7 +633,6 @@ static ssize_t __write_versions(struct file *file, char *buf, size_t size)
> 	}
> 
> 	/* Now write current state into reply buffer */
> -	len = 0;
> 	sep = "";
> 	remaining = SIMPLE_TRANSACTION_LIMIT;
> 	for (num=2 ; num <= 4 ; num++) {
> -- 
> 2.35.3
> 

--
Chuck Lever