linux-kernel - Re: [PATCH AUTOSEL 5.18 24/53] drivers/net/ethernet/neterion/vxge: Fix a use-after-free bug in vxge-main.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220627213847.60d09e43@kernel.org>
Date:   Mon, 27 Jun 2022 21:38:47 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Wentao_Liang <Wentao_Liang_g@....com>,
        "David S . Miller" <davem@...emloft.net>, jdmason@...zu.us,
        edumazet@...gle.com, pabeni@...hat.com, paskripkin@...il.com,
        jgg@...pe.ca, liuhangbin@...il.com, arnd@...db.de,
        christophe.jaillet@...adoo.fr, netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.18 24/53] drivers/net/ethernet/neterion/vxge:
 Fix a use-after-free bug in vxge-main.c

On Mon, 27 Jun 2022 22:18:10 -0400 Sasha Levin wrote:
> From: Wentao_Liang <Wentao_Liang_g@....com>
> 
> [ Upstream commit 8fc74d18639a2402ca52b177e990428e26ea881f ]
> 
> The pointer vdev points to a memory region adjacent to a net_device
> structure ndev, which is a field of hldev. At line 4740, the invocation
> to vxge_device_unregister unregisters device hldev, and it also releases
> the memory region pointed by vdev->bar0. At line 4743, the freed memory
> region is referenced (i.e., iounmap(vdev->bar0)), resulting in a
> use-after-free vulnerability. We can fix the bug by calling iounmap
> before vxge_device_unregister.

This is a dud see commit 877fe9d49b74 ("Revert
"drivers/net/ethernet/neterion/vxge: Fix a use-after-free bug in vxge-main.c"")