linux-kernel - Re: [PATCH v12 3/3] usb: typec: anx7411: Add Analogix PD ANX7411 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YrqdZE7IfKYZHkCu@kroah.com>
Date:   Tue, 28 Jun 2022 08:19:16 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Xin Ji <xji@...logixsemi.com>
Cc:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        bliang@...logixsemi.com, qwen@...logixsemi.com,
        jli@...logixsemi.com, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v12 3/3] usb: typec: anx7411: Add Analogix PD ANX7411
 support

On Tue, Jun 28, 2022 at 12:48:42PM +0800, Xin Ji wrote:
> Add driver for analogix ANX7411 USB Type-C DRP port controller.
> 
> Signed-off-by: Xin Ji <xji@...logixsemi.com>
> ---
> V11 -> V12 : Fix Greg Kroah-Hartman's comment

Which comment?  This is very vague, it's almost like "made changes".

We need specifics here, otherwise it's impossible to review.  Would you
want to see this as a changelog statement for something you spent time
in reviewing?

Also, your changelog itself needs more text, as to what type of device
this is and more information about it if possible.

thanks,

greg k-h