linux-kernel - Re: [PATCH] drm/vc4: fix dereference before NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220628081824.5u4p7q6xepp4uvsd@houat>
Date:   Tue, 28 Jun 2022 10:18:24 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Yu Liao <liaoyu15@...wei.com>
Cc:     emma@...olt.net, eric@...olt.net, bbrezillon@...nel.org,
        liwei391@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/vc4: fix dereference before NULL check

Hi,

On Tue, Jun 28, 2022 at 02:36:57PM +0800, Yu Liao wrote:
> The "perfmon" pointer is equal to the return value of idr_find
> which may be NULL, access by vc4_perfmon_get before checking if
> it was NULL. Fix this by dereferencing "perfmon" after "perfmon"
> has been null checked.
> 
> Addresses-Coverity: ("Dereference before null check")
> Fixes: 65101d8c9108 ("drm/vc4: Expose performance counters to userspace")
> Signed-off-by: Yu Liao <liaoyu15@...wei.com>

A similar patch has already been merged:
https://lore.kernel.org/dri-devel/20220622080243.22119-1-maxime@cerno.tech/

Thanks!
Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)