linux-kernel - Re: [PATCH v2] MIPS: Loongson64: Fix section mismatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a93e5cbe-deb8-c760-685a-6d3171d651f3@loongson.cn>
Date:   Tue, 28 Jun 2022 08:14:45 +0800
From:   Tiezhu Yang <yangtiezhu@...ngson.cn>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Xuefeng Li <lixuefeng@...ngson.cn>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Masahiro Yamada <masahiroy@...nel.org>
Subject: Re: [PATCH v2] MIPS: Loongson64: Fix section mismatch warning

Cc Masahiro Yamada <masahiroy@...nel.org>

On 06/27/2022 03:07 PM, Tiezhu Yang wrote:
> prom_init_numa_memory() is annotated __init and not used by any module,
> thus don't export it.
>
> Remove not needed EXPORT_SYMBOL for prom_init_numa_memory() to fix the
> following section mismatch warning:
>
>   LD      vmlinux.o
>   MODPOST vmlinux.symvers
> WARNING: modpost: vmlinux.o(___ksymtab+prom_init_numa_memory+0x0): Section mismatch in reference
> from the variable __ksymtab_prom_init_numa_memory to the function .init.text:prom_init_numa_memory()
> The symbol prom_init_numa_memory is exported and annotated __init
> Fix this by removing the __init annotation of prom_init_numa_memory or drop the export.
>
> This is build on Linux 5.19-rc4.
>
> Fixes: 6fbde6b492df ("MIPS: Loongson64: Move files to the top-level directory")
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
>
> v2: update the commit message and add Fixes tag
>
>  arch/mips/loongson64/numa.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/loongson64/numa.c b/arch/mips/loongson64/numa.c
> index 69a5331..8f61e93 100644
> --- a/arch/mips/loongson64/numa.c
> +++ b/arch/mips/loongson64/numa.c
> @@ -196,7 +196,6 @@ void __init prom_init_numa_memory(void)
>  	pr_info("CP0_PageGrain: CP0 5.1 (0x%x)\n", read_c0_pagegrain());
>  	prom_meminit();
>  }
> -EXPORT_SYMBOL(prom_init_numa_memory);
>
>  pg_data_t * __init arch_alloc_nodedata(int nid)
>  {
>

Hi Masahiro,

Please review this patch, I think it is related with the following 
issue, thank you.

https://lore.kernel.org/lkml/CAHk-=wgcsUU-TNoLS7Q6YF3RCSVAKwNM7gFOwqnPQTiU_oGEWA@mail.gmail.com/

Thanks,
Tiezhu