linux-kernel - Re: [PATCH 6/6] fanotify: add current_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220628104853.c3gcsvabqv2zzckd@wittgenstein>
Date:   Tue, 28 Jun 2022 12:48:53 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Jan Kara <jack@...e.cz>
Cc:     Guowei Du <duguoweisz@...il.com>, amir73il@...il.com,
        repnop@...gle.com, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, duguowei <duguowei@...omi.com>
Subject: Re: [PATCH 6/6] fanotify: add current_user_instances node

On Tue, Jun 28, 2022 at 12:45:28PM +0200, Jan Kara wrote:
> On Tue 28-06-22 18:14:13, Guowei Du wrote:
> > From: duguowei <duguowei@...omi.com>
> > 
> > Add a node of sysctl, which is current_user_instances.
> > It shows current initialized group counts of system.
> > 
> > Signed-off-by: duguowei <duguowei@...omi.com>
> 
> Hum, I'm not sure about a wider context here but the changelog is certainly
> missing a motivation of this change - why do you need this counter? In
> particular because we already do maintain (and limit) the number of
> fanotify groups each user has allocated in a particular namespace...

Yeah, that's pretty strange as there's
/proc/sys/user/max_fanotify_groups
/proc/sys/user/max_fanotify_marks
it could be to have a ro counter that allows to display the current
number of groups? But that seems strange as we don't expose that
information anywhere for similar things. What would this be used for
even?