linux-kernel - Re: [PATCH v2] ASoC: codecs: wsa883x: add control, dapm widgets and map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c71f751-2f5e-4d1f-5f94-942cf7ad6a8a@linaro.org>
Date:   Wed, 29 Jun 2022 17:10:35 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     alsa-devel@...a-project.org, lgirdwood@...il.com, perex@...ex.cz,
        tiwai@...e.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: codecs: wsa883x: add control, dapm widgets and
 map



On 29/06/2022 16:02, Mark Brown wrote:
> On Wed, Jun 29, 2022 at 03:58:31PM +0100, Srinivas Kandagatla wrote:
> 
>> +static const char * const wsa_dev_mode_text[] = {
>> +	"speaker", "receiver", "ultrasound"
> 
> Idiomatically these would be capitalised ("Speaker" and so on).  Sorry,
> didn't notice on v1.  Otherwise this looks good.
Make sense, Will send v3.

--srini