lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 29 Jun 2022 20:03:55 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     kernel test robot <lkp@...el.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Anitha Chrisanthus <anitha.chrisanthus@...el.com>
Subject: Re: drivers/gpu/drm/kmb/kmb_dsi.c:812:2: warning: unused function 'set_test_mode_src_osc_freq_target_low_bits'

Hi Kernel Test Robot,

On Wed, Jun 29, 2022 at 7:57 PM kernel test robot <lkp@...el.com> wrote:
> First bad commit (maybe != root cause):

Definitely not introduced by my patch.
Looks like these functions were never used at all.

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   d9b2ba67917c18822c6a09af41c32fa161f1606b
> commit: ade896460e4a62f5e4a892a98d254937f6f5b64c drm: DRM_KMB_DISPLAY should depend on ARCH_KEEMBAY
> date:   1 year, 8 months ago
> config: mips-randconfig-r016-20220629 (https://download.01.org/0day-ci/archive/20220630/202206300147.qdDDrtfw-lkp@intel.com/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project a774ba7f60d1fef403b5507b1b1a7475d3684d71)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install mips cross compiling tool for clang build
>         # apt-get install binutils-mipsel-linux-gnu
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ade896460e4a62f5e4a892a98d254937f6f5b64c
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout ade896460e4a62f5e4a892a98d254937f6f5b64c
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/gpu/drm/kmb/ drivers/net/ethernet/mellanox/mlxsw/ drivers/scsi/ufs/ drivers/staging/ fs/xfs/
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@...el.com>
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/gpu/drm/kmb/kmb_dsi.c:812:2: warning: unused function 'set_test_mode_src_osc_freq_target_low_bits'
>    set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi
>    ^
> >> drivers/gpu/drm/kmb/kmb_dsi.c:824:2: warning: unused function 'set_test_mode_src_osc_freq_target_hi_bits'
>    set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi
>    ^
>    fatal error: error in backend: Nested variants found in inline asm string: '.if ( 0x00 ) != -1)) 0x00 ) != -1)) : ($( static struct ftrace_branch_data __attribute__((__aligned__(4))) __attribute__((__section__("_ftrace_branch"))) __if_trace = $( .func = __func__, .file = "arch/mips/include/asm/barrier.h", .line = 16, $); 0x00 ) != -1)) : $))) ) && ( (1 << 0) ); .set push; .set mips64r2; .rept 1; sync 0x00; .endr; .set pop; .else; ; .endif'
>    clang-15: error: clang frontend command failed with exit code 70 (use -v to see invocation)
>    clang version 15.0.0 (git://gitmirror/llvm_project a774ba7f60d1fef403b5507b1b1a7475d3684d71)
>    Target: mipsel-unknown-linux
>    Thread model: posix
>    InstalledDir: /opt/cross/clang-a774ba7f60/bin
>    clang-15: note: diagnostic msg:
>    Makefile arch drivers fs include kernel mm nr_bisected scripts source usr
>
>
> vim +/set_test_mode_src_osc_freq_target_low_bits +812 drivers/gpu/drm/kmb/kmb_dsi.c
>
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  810
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  811  static inline void
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04 @812       set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi *kmb_dsi,
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  813                                                  u32 dphy_no,
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  814                                                  u32 freq)
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  815  {
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  816       /* Typical rise/fall time=166, refer Table 1207 databook,
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  817        * sr_osc_freq_target[7:0]
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  818        */
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  819       test_mode_send(kmb_dsi, dphy_no, TEST_CODE_SLEW_RATE_DDL_CYCLES,
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  820                      (freq & 0x7f));
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  821  }
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  822
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  823  static inline void
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04 @824       set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi,
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  825                                                 u32 dphy_no,
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  826                                                 u32 freq)
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  827  {
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  828       u32 data;
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  829
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  830       /* Flag this as high nibble */
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  831       data = ((freq >> 6) & 0x1f) | (1 << 7);
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  832
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  833       /* Typical rise/fall time=166, refer Table 1207 databook,
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  834        * sr_osc_freq_target[11:7]
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  835        */
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  836       test_mode_send(kmb_dsi, dphy_no, TEST_CODE_SLEW_RATE_DDL_CYCLES, data);
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  837  }
> 98521f4d4b4cb2 Anitha Chrisanthus 2020-11-04  838
>
> :::::: The code at line 812 was first introduced by commit
> :::::: 98521f4d4b4cb265374a4b1e13b41287a1960243 drm/kmb: Mipi DSI part of the display driver
>
> :::::: TO: Anitha Chrisanthus <anitha.chrisanthus@...el.com>
> :::::: CC: Sam Ravnborg <sam@...nborg.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ