linux-kernel - Re: extcon-next: patch "extcon: max77843: Replace irqchip mask_invert with unmask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <88fced25-084f-5a29-8c49-50244e31b98a@gmail.com>
Date:   Thu, 30 Jun 2022 04:09:31 +0900
From:   Chanwoo Choi <cwchoi00@...il.com>
To:     Aidan MacDonald <aidanmacdonald.0x0@...il.com>,
        cw00.choi@...sung.com
Cc:     myungjoo.ham@...sung.com, linux-next@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: extcon-next: patch "extcon: max77843: Replace irqchip mask_invert
 with unmask_base" should be reverted

On 22. 6. 29. 22:09, Aidan MacDonald wrote:
> 
> Hi Chanwoo,
> 
> I just noticed that one of my patches wound up in extcon-next as
> commit a7d674db4612 ("extcon: max77843: Replace irqchip mask_invert
> with unmask_base").
> 
> That patch has been applied too early and should be reverted/dropped,
> as it depends on changes made in my regmap-irq refactoring series[1].
> My commit message was overly broad and didn't communicate that fact,
> however. Unmask registers are in fact broken right now so the patch
> doesn't work as advertised and will break the driver.
> 
> For avoidance of doubt my other two extcon patches you took,
> 
>     extcon: sm5502: Drop useless mask_invert flag on irqchip
>     extcon: rt8973a: Drop useless mask_invert flag on irqchip
> 
> are safe to take early and do not need to be reverted.
> 
> [1]: https://lore.kernel.org/lkml/20220623211420.918875-1-aidanmacdonald.0x0@gmail.com/
> 
> Best regards,
> Aidan

Hi Aidan,

Thanks for the report. I'll drop the patch
as you mentioned[1]

[1] "extcon: max77843: Replace irqchip mask_invert with unmask_base".

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi