linux-kernel - Re: [PATCH] hwmon: (lm90) Use worker for alarm notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14b0ee4f-a12f-ccf2-633a-470be3cdfa38@roeck-us.net>
Date:   Wed, 29 Jun 2022 14:18:11 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Dmitry Osipenko <dmitry.osipenko@...labora.com>,
        linux-hwmon@...r.kernel.org
Cc:     Jean Delvare <jdelvare@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (lm90) Use worker for alarm notifications

On 6/29/22 13:02, Dmitry Osipenko wrote:
> On 6/29/22 18:42, Guenter Roeck wrote:
>> Reporting alarms using hwmon_notify_event() may result in a callback
>> from the thermal subsystem. This means that such notifications must
>> not hold the update lock to avoid a deadlock. To avoid this situation,
>> use a worker to handle notifications.
>>
>> Reported-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>
>> Fixes: e182cf579f0f ("hwmon: (lm90) Rework alarm/status handling")
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>> ---
>> Dmitry,
>>
>> can you give this patch a try in your system ?
> 
> It works, thanks!
> 
> Tested-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>
> 
Thanks a lot for testing!

Guenter