linux-kernel - Re: [PATCH] ata: pata_cs5535: Fix W=1 warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9448ff77-9b0e-95fd-1366-a5103fdb3ea0@opensource.wdc.com>
Date:   Thu, 30 Jun 2022 08:03:57 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     Sergey Shtylyov <s.shtylyov@....ru>,
        John Garry <john.garry@...wei.com>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: pata_cs5535: Fix W=1 warnings

On 6/29/22 22:32, Sergey Shtylyov wrote:
> On 6/29/22 4:51 AM, Damien Le Moal wrote:
> 
>>> x86_64 allmodconfig build with W=1 gives these warnings:
>>>
>>> drivers/ata/pata_cs5535.c: In function ‘cs5535_set_piomode’:
>>> drivers/ata/pata_cs5535.c:93:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
>>>   u32 reg, dummy;
>>>            ^~~~~
>>> drivers/ata/pata_cs5535.c: In function ‘cs5535_set_dmamode’:
>>> drivers/ata/pata_cs5535.c:132:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
>>>   u32 reg, dummy;
>>>            ^~~~~
>>> cc1: all warnings being treated as errors
>>>
>>> Mark variables 'dummy' as "maybe unused" to satisfy when rdmsr() is
>>> stubbed, which is the same as what we already do in pata_cs5536.c .
>>>
>>> Signed-off-by: John Garry <john.garry@...wei.com>
>>
>> Applied to for-5.20. Thanks !
> 
>    Why not to 5.19? The warnings are fatal as can be seen from the commit log...

This is only a compile warning and nobody complained, not even the 0-day
bot/linux-next builds, and for years... Most definitely not an urgent fix.

But yeah, sure, can do 5.19 fixes too.

> 
> MBR, Sergey
> 


-- 
Damien Le Moal
Western Digital Research