linux-kernel - Re: [PATCH] kvm: nVMX: add tracepoint for kvm:kvm_nested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yrzb8c3g6C/aL8+B@google.com>
Date:   Wed, 29 Jun 2022 23:10:41 +0000
From:   Mingwei Zhang <mizhang@...gle.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm <kvm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        David Matlack <dmatlack@...gle.com>
Subject: Re: [PATCH] kvm: nVMX: add tracepoint for kvm:kvm_nested_vmrun


> > diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> > index f5cb18e00e78..29cc36cf2568 100644
> > --- a/arch/x86/kvm/vmx/nested.c
> > +++ b/arch/x86/kvm/vmx/nested.c
> > @@ -3367,6 +3367,13 @@ enum nvmx_vmentry_status nested_vmx_enter_non_root_mode(struct kvm_vcpu *vcpu,
> >       };
> >       u32 failed_index;
> >
> > +     trace_kvm_nested_vmrun(
> > +             kvm_rip_read(vcpu), vmx->nested.current_vmptr,
> > +             vmcs12->guest_rip,
>
> Be consistent; either put each parameter on it's own line or wrap only when
> necessary.

will do.

>
> > +             vmcs12->guest_intr_status,
> > +             vmcs12->vm_entry_intr_info_field,
> > +             vmcs12->secondary_vm_exec_control & SECONDARY_EXEC_ENABLE_EPT);
> > +
>
> Align the parameters to the opening '(', that "rule" trumps the 80 char soft limit.

will do.

>
>         trace_kvm_nested_vmrun(kvm_rip_read(vcpu),
>                                vmx->nested.current_vmptr,
>                                vmcs12->guest_rip,
>                                vmcs12->guest_intr_status,
>                                vmcs12->vm_entry_intr_info_field,
>                                vmcs12->secondary_vm_exec_control & SECONDARY_EXEC_ENABLE_EPT);
>
> And if we're going to add nVMX, we should clean up the tracepoint output.  E.g.
> pass in KVM_ISA_{SVM,VMX} to different VMCB vs. VMCS and npt vs. ept (and maybe
> print nNPT and nEPT to make it obvious it's the vmcs12 setting?).  The "nrip"
> field is wrong even for SVM; the tracepoint prints the L2 rip, not the next_rip
> field in vmcs12.  Maybe "L2 rip"?

I can change the 'nrip' to 'nested rip', since it may not necessarily
the 'L2 rip'.

For the others, will do.