linux-kernel - Re: [PATCH v8 2/2] On Semi AR0521 sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YrziTabYLlZ2bX+1@valkosipuli.retiisi.eu>
Date:   Thu, 30 Jun 2022 02:37:49 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Krzysztof Hałasa <khalasa@...p.pl>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Jacopo Mondi <jacopo@...ndi.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v8 2/2] On Semi AR0521 sensor driver

Hi Krzysztof,

On Fri, May 06, 2022 at 08:10:16AM +0200, Krzysztof Hałasa wrote:
> Hi Mauro et al,
> 
> Mauro, you are the drivers/media maintainer. Is the AR0521 driver ready
> to be merged, are there still unresolved issues, or the driver is not no
> be merged at all? I understand everyone's so busy but a simple yes or no
> isn't too much, is it?

Apologies for the late reply.

Please run checkpatch.pl --strict --max-line-length=80 on the patch in the
future. Some of the output is often troublesome to address though. I've
applied it with these changes:

diff --git a/drivers/media/i2c/ar0521.c b/drivers/media/i2c/ar0521.c
index 1cce512ff62b0..9c7a07d31ace6 100644
--- a/drivers/media/i2c/ar0521.c
+++ b/drivers/media/i2c/ar0521.c
@@ -347,8 +347,10 @@ static int ar0521_set_stream(struct ar0521_dev *sensor, bool on)
 		return ret;
 
 	} else {
-		/* Reset gain, the sensor may produce all white pixels without
-		   this */
+		/*
+		 * Reset gain, the sensor may produce all white pixels without
+		 * this
+		 */
 		ret = ar0521_write_reg(sensor, AR0521_REG_GLOBAL_GAIN, 0x2000);
 		if (ret)
 			return ret;
@@ -1056,4 +1058,4 @@ module_i2c_driver(ar0521_i2c_driver);
 
 MODULE_DESCRIPTION("AR0521 MIPI Camera subdev driver");
 MODULE_AUTHOR("Krzysztof Hałasa <khalasa@...p.pl>");
-MODULE_LICENSE("GPL v2");
+MODULE_LICENSE("GPL");

-- 
Kind regards,

Sakari Ailus