linux-kernel - RE: [PATCH v9 1/2] thermal: Add thermal driver for Sunplus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <254b6c711c9a464cb23d1eb5957a6af9@sphcmbx01.sunplus.com.tw>
Date:   Wed, 29 Jun 2022 03:31:48 +0000
From:   Lh Kuo 郭力豪 <lh.Kuo@...plus.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        郭力豪 <lhjeff911@...il.com>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        "amitk@...nel.org" <amitk@...nel.org>,
        "rui.zhang@...el.com" <rui.zhang@...el.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v9 1/2] thermal: Add thermal driver for Sunplus

I'm sorry for the wrong indentation problem, it was caused by a wrong setting in the mail server.I will fix it in the next patch.

> -----Original Message-----
> From: Randy Dunlap <rdunlap@...radead.org>
> Sent: Friday, June 10, 2022 11:20 AM
> To: 郭力豪 <lhjeff911@...il.com>; krzk@...nel.org; rafael@...nel.org; Daniel Lezcano
> <daniel.lezcano@...aro.org>; amitk@...nel.org; rui.zhang@...el.com; robh+dt@...nel.org;
> linux-pm@...r.kernel.org; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Lh Kuo 郭力豪 <lh.Kuo@...plus.com>; Wells Lu 呂芳騰 <wells.lu@...plus.com>
> Subject: Re: [PATCH v9 1/2] thermal: Add thermal driver for Sunplus
> 
> Hi--
> 
> On 6/9/22 18:32, 郭力豪 wrote:
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index
> > 0e5cc94..c85e668 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -504,4 +504,14 @@ config KHADAS_MCU_FAN_THERMAL
> >     If you say yes here you get support for the FAN controlled
> >     by the Microcontroller found on the Khadas VIM boards.
> >
> > +config SUNPLUS_THERMAL
> > + tristate "Sunplus thermal drivers"
> > + depends on SOC_SP7021 || COMPILE_TEST  help
> > +   This enable the Sunplus SP7021 thermal driver, which supports the primitive
> > +   temperature sensor embedded in Sunplus SP7021 SoC.
> > +
> > +   If you have a Sunplus SP7021 platform say Y here and enable this option
> > +   to have support for thermal management
> 
> End the sentence above with a period ('.').
> 
> And the indentation here is all messed up.
> See Documentation/process/coding-style.rst:
> 
> 10) Kconfig configuration files
> -------------------------------
> 
> For all of the Kconfig* configuration files throughout the source tree, the indentation is somewhat
> different.  Lines under a ``config`` definition are indented with one tab, while help text is indented an
> additional two spaces.
> 
> 
> > +
> >  endif
> 
> --
> ~Randy