linux-kernel - Re: [PATCH 3/3] staging: Thunderbolt: ctl.c: Fixed comment coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Jun 2022 09:02:52 +0200
From:   Greg KH <greg@...ah.com>
To:     Gabriel Viso Carrera <gabriel@...soc.com>
Cc:     Joe Perches <joe@...ches.com>, andreas.noever@...il.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] staging: Thunderbolt: ctl.c: Fixed comment coding
 style issues

On Wed, Jun 29, 2022 at 04:54:53PM +1000, Gabriel Viso Carrera wrote:
> On Sat, Jun 25, 2022 at 02:37:54AM -0700, Joe Perches wrote:
> []
> > 
> > I'd indent this only 1 level and put it before the call
> > (and fix the loose/lose typo)
> > 
> > {
> > 	/* We ignore failures during stop.
> > 	 * All rx packets are referenced from ctl->rx_packets,
> > 	 * so we do not lose them.
> > 	 */
> > 	tb_ring_rx(pkg->ctl->rx, &pkg->frame);
> > }
> > 
> 
> Fair enough. Not sure on how to proceed, as these were my 
> first patches ever sent, and I don't want to make anyone 
> work more than the strictly necessary. 

If you are just learning how to do all of this, I strongly recommend you
stick to drivers/staging/* which is much more forgiving and welcoming
for basic coding style cleanups.  After you get some experience there,
then go out into other subsystems.  Many subsystems do not like coding
style fixes as it causes conflicts with other development that is
happening.

thanks,

greg k-h