linux-kernel - Re: [PATCH 0/4] KUnit tests for RGB565 conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2c1e02a-46e1-5d4e-bdba-f89e2ca4e6d1@suse.de>
Date:   Wed, 29 Jun 2022 09:37:13 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     José Expósito <jose.exposito89@...il.com>,
        javierm@...hat.com
Cc:     davidgow@...gle.com, dlatypov@...gle.com, mripard@...nel.org,
        daniel@...ll.ch, airlied@...ux.ie,
        maarten.lankhorst@...ux.intel.com, jani.nikula@...ux.intel.com,
        maira.canal@....br, isabbasso@...eup.net, magalilemes00@...il.com,
        tales.aparecida@...il.com, dri-devel@...ts.freedesktop.org,
        kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] KUnit tests for RGB565 conversion

Hi

Am 27.06.22 um 18:11 schrieb José Expósito:
> Hello everyone,
> 
> This series is a follow up of the XRGB8888 to RGB332 conversion KUnit tests.
> 
> The first 3 patches refactor the existing test to make them agnostic of the target format and add support for "swab".
> 
> The last patch adds the RGB565 conversion values, and shows how more formats will be easily added in the future.

Thanks for your patches. I had one comment for the final one. With this 
fixed, you can add

Acked-by: Thomas Zimmermann <tzimmermann@...e.de>

to the series.

Best regards
Thomas

> 
> Thank you very much in advance for your feedback,
> José Expósito
> 
> José Expósito (4):
>    drm/format-helper: Rename test cases to make them more generic
>    drm/format-helper: Transform tests to be agnostic of target format
>    drm/format-helper: Add support for conversion functions with swab
>    drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb565()
> 
>   .../gpu/drm/tests/drm_format_helper_test.c    | 231 +++++++++++++++---
>   1 file changed, 196 insertions(+), 35 deletions(-)
> 
> 
> base-commit: 6fde8eec71796f3534f0c274066862829813b21f
> prerequisite-patch-id: 8a16f4c8004d6161035eaea275c8eafaa0ac927e
> prerequisite-patch-id: 53fded2a49e6212b546db76ec52563a683752e65
> prerequisite-patch-id: 294b0ca27a6ee57096c8f097c0572336b8a2d583
> prerequisite-patch-id: 5e05bfc5287d16c207bfc616b2776ad72eb4ab29
> prerequisite-patch-id: e94560be85dffb62a5b3cf58d1f0fc3d278ad806
> prerequisite-patch-id: a471df39c7b32c69dd2b138a7d0af015ea42e00a

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)