lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Jun 2022 11:23:51 +0300 From: Dmitry Osipenko <dmitry.osipenko@...labora.com> To: Thomas Hellström (Intel) <thomas_os@...pmail.org>, David Airlie <airlied@...ux.ie>, Gerd Hoffmann <kraxel@...hat.com>, Gurchetan Singh <gurchetansingh@...omium.org>, Chia-I Wu <olvaffe@...il.com>, Daniel Vetter <daniel@...ll.ch>, Daniel Almeida <daniel.almeida@...labora.com>, Gert Wollny <gert.wollny@...labora.com>, Gustavo Padovan <gustavo.padovan@...labora.com>, Daniel Stone <daniel@...ishbar.org>, Tomeu Vizoso <tomeu.vizoso@...labora.com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring <robh@...nel.org>, Steven Price <steven.price@....com>, Alyssa Rosenzweig <alyssa.rosenzweig@...labora.com>, Rob Clark <robdclark@...il.com>, Emil Velikov <emil.l.velikov@...il.com>, Robin Murphy <robin.murphy@....com>, Qiang Yu <yuq825@...il.com>, Sumit Semwal <sumit.semwal@...aro.org>, Christian König <christian.koenig@....com>, "Pan, Xinhui" <Xinhui.Pan@....com>, Thierry Reding <thierry.reding@...il.com>, Tomasz Figa <tfiga@...omium.org>, Marek Szyprowski <m.szyprowski@...sung.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Alex Deucher <alexander.deucher@....com>, Jani Nikula <jani.nikula@...ux.intel.com>, Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>, Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com> Cc: intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, virtualization@...ts.linux-foundation.org, linaro-mm-sig@...ts.linaro.org, amd-gfx@...ts.freedesktop.org, linux-tegra@...r.kernel.org, Dmitry Osipenko <digetx@...il.com>, kernel@...labora.com, linux-media@...r.kernel.org Subject: Re: [PATCH v6 01/22] drm/gem: Properly annotate WW context on drm_gem_lock_reservations() error On 6/28/22 23:12, Thomas Hellström (Intel) wrote: > Hi, > > On 5/27/22 01:50, Dmitry Osipenko wrote: >> Use ww_acquire_fini() in the error code paths. Otherwise lockdep >> thinks that lock is held when lock's memory is freed after the >> drm_gem_lock_reservations() error. The WW needs to be annotated >> as "freed" > > s /WW/ww_acquire_context/ ? > s /"freed"/"released"/ ? > > >> , which fixes the noisy "WARNING: held lock freed!" splat >> of VirtIO-GPU driver with CONFIG_DEBUG_MUTEXES=y and enabled lockdep. >> >> Cc: stable@...r.kernel.org > > Can you dig up the commit in error and add a Fixes: Tag? > > Using that and "dim fixes" will also make the Cc: stable tag a bit more > verbose. > > With that fixed, > > Reviewed-by: Thomas Hellström <thomas.hellstrom@...ux.intel.com> I'll update this patch, thank you for taking a look. -- Best regards, Dmitry
Powered by blists - more mailing lists