linux-kernel - Re: [PATCH v1] Fix: SYNCOBJ TIMELINE Test failed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Jun 2022 11:12:27 +0200
From:   Christian König <christian.koenig@....com>
To:     jie1zhan <jesse.zhang@....com>, broonie@...nel.org,
        alsa-devel@...a-project.org
Cc:     Vijendar.Mukunda@....com, Basavaraj.Hiregoudar@....com,
        Sunil-kumar.Dommati@....com, ajitkumar.pandey@....com,
        Nirmoy Das <nirmoy.das@...ux.intel.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:DMA BUFFER SHARING FRAMEWORK" 
        <linux-media@...r.kernel.org>,
        "moderated list:DMA BUFFER SHARING FRAMEWORK" 
        <linaro-mm-sig@...ts.linaro.org>
Subject: Re: [PATCH v1] Fix: SYNCOBJ TIMELINE Test failed.

Am 29.06.22 um 08:02 schrieb jie1zhan:
>   The issue cause by the commit :
>
> 721255b527(drm/syncobj: flatten dma_fence_chains on transfer).
>
> Because it use the point of dma_fence incorrectly
>
> Correct the point of dma_fence by fence array

Well that patch is just utterly nonsense as far as I can see.

>
> Signed-off-by: jie1zhan <jesse.zhang@....com>
>
> Reviewed-by: Christian König <christian.koenig@....com>
>
> Reviewed-by: Nirmoy Das <nirmoy.das@...ux.intel.com>

I have strong doubts that Nirmoy has reviewed this and I certainly 
haven't reviewed it.

Christian.

> ---
>   drivers/gpu/drm/drm_syncobj.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index 7e48dcd1bee4..d5db818f1c76 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -887,7 +887,7 @@ static int drm_syncobj_flatten_chain(struct dma_fence **f)
>   		goto free_fences;
>   
>   	dma_fence_put(*f);
> -	*f = &array->base;
> +	*f = array->fences[0];
>   	return 0;
>   
>   free_fences: