linux-kernel - Re: [PATCH v2 2/2] NFC: nxp-nci: don't print header length mismatch on i2c error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33def8ba-2ca3-c2a3-57ff-9b20dbc2337c@linaro.org>
Date:   Wed, 29 Jun 2022 11:21:29 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Michael Walle <michael@...le.cc>
Cc:     Clément Perrochaud <clement.perrochaud@....com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] NFC: nxp-nci: don't print header length mismatch
 on i2c error

On 27/06/2022 19:06, Michael Walle wrote:
> Don't print a misleading header length mismatch error if the i2c call
> returns an error. Instead just return the error code without any error
> message.
> 
> Signed-off-by: Michael Walle <michael@...le.cc>
> ---
> changes since v1:
>  - reworded commit message
>  - removed fixes tag
>  - removed nfc_err() call, as it is done elsewhere in this driver
>  - nxp_nci_i2c_fw_read() has the same issue. also handle it there
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>


Best regards,
Krzysztof