linux-kernel - Re: [PATCH] net: dsa: rzn1-a5psw: fix a NULL vs IS_ERR() check in a5psw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Jun 2022 11:27:20 +0200
From:   Clément Léger <clement.leger@...tlin.com>
To:     Peng Wu <wupeng58@...wei.com>
Cc:     <andrew@...n.ch>, <vivien.didelot@...il.com>,
        <f.fainelli@...il.com>, <olteanv@...il.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <linux-renesas-soc@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <liwei391@...wei.com>
Subject: Re: [PATCH] net: dsa: rzn1-a5psw: fix a NULL vs IS_ERR() check in
 a5psw_probe()

Le Tue, 28 Jun 2022 13:09:20 +0000,
Peng Wu <wupeng58@...wei.com> a écrit :

> The devm_platform_ioremap_resource() function never returns NULL.
> It returns error pointers.
> 
> Signed-off-by: Peng Wu <wupeng58@...wei.com>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> ---
>  drivers/net/dsa/rzn1_a5psw.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c
> index 3e910da98ae2..5b14e2ba9b79 100644
> --- a/drivers/net/dsa/rzn1_a5psw.c
> +++ b/drivers/net/dsa/rzn1_a5psw.c
> @@ -946,8 +946,8 @@ static int a5psw_probe(struct platform_device *pdev)
>  	mutex_init(&a5psw->lk_lock);
>  	spin_lock_init(&a5psw->reg_lock);
>  	a5psw->base = devm_platform_ioremap_resource(pdev, 0);
> -	if (!a5psw->base)
> -		return -EINVAL;
> +	if (IS_ERR(a5psw->base))
> +		return PTR_ERR(a5psw->base);
>  
>  	ret = a5psw_pcs_get(a5psw);
>  	if (ret)

Thanks,

Reviewed-by: Clément Léger <clement.leger@...tlin.com>

-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com