linux-kernel - Re: [PATCH 6/6] vduse: Update api version to 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACycT3vg=_crxQQfkmUYyG1tCWTVidiBssQn+xxMYe_7vAM-KA@mail.gmail.com>
Date:   Wed, 29 Jun 2022 17:28:55 +0800
From:   Yongji Xie <xieyongji@...edance.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     Jason Wang <jasowang@...hat.com>,
        Liu Xiaodong <xiaodong.liu@...el.com>,
        Maxime Coquelin <maxime.coquelin@...hat.com>,
        Stefan Hajnoczi <stefanha@...hat.com>,
        virtualization <virtualization@...ts.linux-foundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/6] vduse: Update api version to 1

On Wed, Jun 29, 2022 at 5:22 PM Michael S. Tsirkin <mst@...hat.com> wrote:
>
> On Wed, Jun 29, 2022 at 05:02:40PM +0800, Yongji Xie wrote:
> > On Wed, Jun 29, 2022 at 4:33 PM Michael S. Tsirkin <mst@...hat.com> wrote:
> > >
> > > On Wed, Jun 29, 2022 at 04:25:41PM +0800, Xie Yongji wrote:
> > > > Let's update api version to 1 since we introduced
> > > > some new ioctls to support registering userspace
> > > > memory for IOTLB.
> > > >
> > > > Signed-off-by: Xie Yongji <xieyongji@...edance.com>
> > >
> > >
> > > Adding new ioctls does not justify things like this.
> > >
> >
> > What I want to do here is make userspace know whether this feature is
> > supported or not in the kernel. So do you think we need to add
> > something like CHECK_EXTENSION ioctl here?
>
> Why bother? unsupported ioctls just return an error code.
>

Oh, yes. I forgot the error code of the ioctls.

Thanks,
Yongji