[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <62bc2c1d.1c69fb81.09d2.e244@mx.google.com>
Date: Wed, 29 Jun 2022 12:40:27 +0200
From: Christian Marangi <ansuelsmth@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Andy Gross <agross@...nel.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, Jens Axboe <axboe@...nel.dk>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH v3 2/4] dt-bindings: arm: msm: Convert kpss-acc driver
Documentation to yaml
On Wed, Jun 29, 2022 at 08:14:12AM +0200, Krzysztof Kozlowski wrote:
> On 28/06/2022 20:41, Christian Marangi wrote:
> > Convert kpss-acc driver Documentation to yaml.
> > The original Documentation was wrong all along. Fix it while we are
> > converting it.
> > The example was wrong as kpss-acc-v2 should only expose the regs but we
> > don't have any driver that expose additional clocks. The kpss-acc driver
> > is only specific to v1. For this exact reason, limit all the additional
> > bindings (clocks, clock-names, clock-output-names and #clock-cells) to
> > v1 and also flag that these bindings should NOT be used for v2.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
>
> This is still not fixed and not tested. Since 4 versions of this
> patchset (previously was part of other set).
>
> I retract my review. Please test the bindings.
>
> Best regards,
> Krzysztof
Thing is that I tested them and on my side I don't have such errors.
I'm using the linux-next branch. Should I use something else that have
newer schema files?
Also on other patch there are some error reported that are unrelated to
my change and that looks strange.
--
Ansuel
Powered by blists - more mailing lists