linux-kernel - Re: [PATCH] lib/scatterlist: use matched parameter type when call __sg_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 29 Jun 2022 20:43:35 +0800
From:   Ming Lei <ming.lei@...hat.com>
To:     wuchi <wuchi.zero@...il.com>
Cc:     maorg@...dia.com, hch@....de, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/scatterlist: use matched parameter type when call
 __sg_free_table

On Wed, Jun 29, 2022 at 11:02:41AM +0800, wuchi wrote:
> commit <4635873c561a> (scsi: lib/sg_pool.c: improve APIs for
> allocating sg pool) had change @(bool)skip_first_chunk of
> __sg_free_table to @(unsigned int)nents_first_chunk, so use unsigend
> int type instead of bool type (false -> 0) when call the function in
> sg_free_append_table and sg_free_table.
> 
> Signed-off-by: wuchi <wuchi.zero@...il.com>
> ---
>  lib/scatterlist.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/scatterlist.c b/lib/scatterlist.c
> index d5e82e4a57ad..c8c3d675845c 100644
> --- a/lib/scatterlist.c
> +++ b/lib/scatterlist.c
> @@ -240,7 +240,7 @@ EXPORT_SYMBOL(__sg_free_table);
>   **/
>  void sg_free_append_table(struct sg_append_table *table)
>  {
> -	__sg_free_table(&table->sgt, SG_MAX_SINGLE_ALLOC, false, sg_kfree,
> +	__sg_free_table(&table->sgt, SG_MAX_SINGLE_ALLOC, 0, sg_kfree,
>  			table->total_nents);
>  }
>  EXPORT_SYMBOL(sg_free_append_table);
> @@ -253,7 +253,7 @@ EXPORT_SYMBOL(sg_free_append_table);
>   **/
>  void sg_free_table(struct sg_table *table)
>  {
> -	__sg_free_table(table, SG_MAX_SINGLE_ALLOC, false, sg_kfree,
> +	__sg_free_table(table, SG_MAX_SINGLE_ALLOC, 0, sg_kfree,
>  			table->orig_nents);
>  }
>  EXPORT_SYMBOL(sg_free_table);

Reviewed-by: Ming Lei <ming.lei@...hat.com>


Thanks,
Ming