linux-kernel - Re: [PATCH V13 09/13] irqchip/loongson-liointc: Add ACPI init support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Jun 2022 14:13:53 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Jianmin Lv <lvjianmin@...ngson.cn>
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
        Hanjun Guo <guohanjun@...wei.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Huacai Chen <chenhuacai@...ngson.cn>
Subject: Re: [PATCH V13 09/13] irqchip/loongson-liointc: Add ACPI init support

On Mon, 27 Jun 2022 12:39:53 +0100,
Jianmin Lv <lvjianmin@...ngson.cn> wrote:
> 
> From: Huacai Chen <chenhuacai@...ngson.cn>
> 
> We are preparing to add new Loongson (based on LoongArch, not compatible
> with old MIPS-based Loongson) support. LoongArch use ACPI other than DT
> as its boot protocol, so add ACPI init support.
> 
> LIOINTC stands for "Legacy I/O Interrupts" that described in Section
> 11.1 of "Loongson 3A5000 Processor Reference Manual". For more
> information please refer Documentation/loongarch/irq-chip-model.rst.

This is what happens with this series while compiling for MIPS:

drivers/irqchip/irq-loongson-liointc.c: In function ‘liointc_domain_xlate’:
drivers/irqchip/irq-loongson-liointc.c:170:28: error: ‘GSI_MIN_CPU_IRQ’ undeclared (first use in this function)
  170 |  *out_hwirq = intspec[0] - GSI_MIN_CPU_IRQ;
      |                            ^~~~~~~~~~~~~~~

I haven't bothered reviewing more patches, as this is a waste of my
time.

	M.

-- 
Without deviation from the norm, progress is not possible.