linux-kernel - Re: [PATCH net-next] net: phy: micrel: Adding LED feature for LAN8814 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YrxXL/p3q35SsXmk@shell.armlinux.org.uk>
Date:   Wed, 29 Jun 2022 14:44:15 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Divya Koppera <Divya.Koppera@...rochip.com>, hkallweit1@...il.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, UNGLinuxDriver@...rochip.com,
        Madhuri.Sripada@...rochip.com
Subject: Re: [PATCH net-next] net: phy: micrel: Adding LED feature for
 LAN8814 PHY

On Tue, Jun 28, 2022 at 04:33:53PM +0200, Andrew Lunn wrote:
> On Tue, Jun 28, 2022 at 11:19:25AM +0530, Divya Koppera wrote:
> > LED support for extended mode where
> > LED 1: Enhanced Mode 5 (10M/1000M/Activity)
> > LED 2: Enhanced Mode 4 (100M/1000M/Activity)
> > 
> > By default it supports KSZ9031 LED mode
> 
> You need to update the binding documentation.

What happened to "use the LEDs interface, don't invent private bindings
for PHY LEDs" ?

Does this mean the private bindings are now acceptable and I can
resubmit my 88x3310 LED support code?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!