linux-kernel - [gfs2:nopid 1/5] fs/gfs2/glock.c:2759:36: error: implicit declaration of function 'task_active_pid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202206291026.52o1nw9J-lkp@intel.com>
Date:   Wed, 29 Jun 2022 11:02:29 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andreas Gruenbacher <agruenba@...hat.com>
Cc:     kbuild-all@...ts.01.org, cluster-devel@...hat.com,
        linux-kernel@...r.kernel.org
Subject: [gfs2:nopid 1/5] fs/gfs2/glock.c:2759:36: error: implicit
 declaration of function 'task_active_pid_ns'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git nopid
head:   b1d0ed94e881ca5b5aee15e05f13db75445398f2
commit: 13ba8572506201aa85020970f776597fbcdcda56 [1/5] gfs2: Add glockfd debugfs file
config: csky-randconfig-r025-20220627 (https://download.01.org/0day-ci/archive/20220629/202206291026.52o1nw9J-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?id=13ba8572506201aa85020970f776597fbcdcda56
        git remote add gfs2 https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git
        git fetch --no-tags gfs2 nopid
        git checkout 13ba8572506201aa85020970f776597fbcdcda56
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=csky SHELL=/bin/bash fs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   fs/gfs2/glock.c: In function 'gfs2_glockfd_next_task':
>> fs/gfs2/glock.c:2759:36: error: implicit declaration of function 'task_active_pid_ns' [-Werror=implicit-function-declaration]
    2759 |         struct pid_namespace *ns = task_active_pid_ns(current);
         |                                    ^~~~~~~~~~~~~~~~~~
   fs/gfs2/glock.c:2759:36: warning: initialization of 'struct pid_namespace *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
   fs/gfs2/glock.c: In function 'gfs2_glockfd_next_file':
>> fs/gfs2/glock.c:2785:17: error: implicit declaration of function 'fput'; did you mean 'iput'? [-Werror=implicit-function-declaration]
    2785 |                 fput(i->file);
         |                 ^~~~
         |                 iput
   cc1: some warnings being treated as errors


vim +/task_active_pid_ns +2759 fs/gfs2/glock.c

  2756	
  2757	static struct task_struct *gfs2_glockfd_next_task(struct gfs2_glockfd_iter *i)
  2758	{
> 2759		struct pid_namespace *ns = task_active_pid_ns(current);
  2760		struct pid *pid;
  2761	
  2762		if (i->task)
  2763			put_task_struct(i->task);
  2764	
  2765		rcu_read_lock();
  2766	retry:
  2767		i->task = NULL;
  2768		pid = find_ge_pid(i->tgid, ns);
  2769		if (pid) {
  2770			i->tgid = pid_nr_ns(pid, ns);
  2771			i->task = pid_task(pid, PIDTYPE_TGID);
  2772			if (!i->task) {
  2773				i->tgid++;
  2774				goto retry;
  2775			}
  2776			get_task_struct(i->task);
  2777		}
  2778		rcu_read_unlock();
  2779		return i->task;
  2780	}
  2781	
  2782	static struct file *gfs2_glockfd_next_file(struct gfs2_glockfd_iter *i)
  2783	{
  2784		if (i->file) {
> 2785			fput(i->file);
  2786			i->file = NULL;
  2787		}
  2788	
  2789		rcu_read_lock();
  2790		for(;; i->fd++) {
  2791			struct inode *inode;
  2792	
  2793			i->file = task_lookup_next_fd_rcu(i->task, &i->fd);
  2794			if (!i->file) {
  2795				i->fd = 0;
  2796				break;
  2797			}
  2798			inode = file_inode(i->file);
  2799			if (inode->i_sb != i->sb)
  2800				continue;
  2801			if (get_file_rcu(i->file))
  2802				break;
  2803		}
  2804		rcu_read_unlock();
  2805		return i->file;
  2806	}
  2807	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp