linux-kernel - Re: [PATCH v3 13/15] riscv: dts: canaan: fix bus {ranges,reg} warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <026527d3-ef75-92aa-36ab-32da47cca418@microchip.com>
Date:   Thu, 30 Jun 2022 19:31:20 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <Niklas.Cassel@....com>
CC:     <airlied@...ux.ie>, <daniel@...ll.ch>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <thierry.reding@...il.com>,
        <sam@...nborg.org>, <Eugeniy.Paltsev@...opsys.com>,
        <vkoul@...nel.org>, <lgirdwood@...il.com>, <broonie@...nel.org>,
        <fancer.lancer@...il.com>, <daniel.lezcano@...aro.org>,
        <palmer@...belt.com>, <palmer@...osinc.com>, <tglx@...utronix.de>,
        <paul.walmsley@...ive.com>, <aou@...s.berkeley.edu>,
        <masahiroy@...nel.org>, <damien.lemoal@...nsource.wdc.com>,
        <geert@...ux-m68k.org>, <dillon.minfei@...il.com>,
        <joabreu@...opsys.com>, <dri-devel@...ts.freedesktop.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <dmaengine@...r.kernel.org>, <alsa-devel@...a-project.org>,
        <linux-spi@...r.kernel.org>, <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH v3 13/15] riscv: dts: canaan: fix bus {ranges,reg}
 warnings

On 30/06/2022 18:02, Conor Dooley wrote:
> 
> 
> On 30/06/2022 17:49, Niklas Cassel wrote:
>> On Wed, Jun 29, 2022 at 07:43:42PM +0100, Conor Dooley wrote:
>>> From: Conor Dooley <conor.dooley@...rochip.com>
>>>
>>> The k210 devicetrees warn about missing/empty reg and/or ranges
>>> properties:
>>> arch/riscv/boot/dts/canaan/k210.dtsi:408.22-460.5: Warning (unit_address_vs_reg): /soc/bus@...00000: node has a unit name, but no reg or ranges property
>>> arch/riscv/boot/dts/canaan/k210.dtsi:352.22-406.5: Warning (simple_bus_reg): /soc/bus@...00000: missing or empty reg/ranges property
>>>
>>> Add reg and ranges properties that naively cap the buses after the
>>> allocation of their last devices.
>>>
>>> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
>>> ---
>>>  arch/riscv/boot/dts/canaan/k210.dtsi | 9 ++++++---
>>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/riscv/boot/dts/canaan/k210.dtsi b/arch/riscv/boot/dts/canaan/k210.dtsi
>>> index 948dc235e39d..6a34dc4f3e51 100644
>>> --- a/arch/riscv/boot/dts/canaan/k210.dtsi
>>> +++ b/arch/riscv/boot/dts/canaan/k210.dtsi
>>> @@ -163,7 +163,8 @@ apb0: bus@...00000 {
>>>  			#address-cells = <1>;
>>>  			#size-cells = <1>;
>>>  			compatible = "simple-pm-bus";
>>> -			ranges;
>>> +			regs = <0x50200000 0x200000>;
>>> +			ranges = <0x50200000 0x50200000 0x200000>;
>>
>> This looks wrong.
>>
>> The property is called "reg" not "regs".
> 
> Yeah...
> 
>>
>> And I don't think that you should provide "reg" at all,
>> simply supplying "ranges" should be sufficient, no?
> 
> I don't recall why I put the regs in, I'll drop it if
> possible & respond if I can't.
> IIRC, it did actually complain.

It does not complain. Good spot, thanks.
I'll drop "regs" for v4.
Conor.