linux-kernel - Re: [PATCH v5 2/2] ASoC: cs35l41: Read System Name from ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b080405b-d1af-8a32-a429-b09250489f0c@linux.intel.com>
Date:   Thu, 30 Jun 2022 14:50:10 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Stefan Binding <sbinding@...nsource.cirrus.com>,
        alsa-devel@...a-project.org,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        patches@...nsource.cirrus.com, Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        Len Brown <lenb@...nel.org>
Subject: Re: [PATCH v5 2/2] ASoC: cs35l41: Read System Name from ACPI _SUB to
 identify firmware



On 6/30/22 14:34, Mark Brown wrote:
> On Thu, Jun 30, 2022 at 01:35:05PM -0500, Pierre-Louis Bossart wrote:
> 
>> It's my understanding that the _SUB method is optional, not required. It
>> may be wise to plan for a fallback, e.g to use DMI quirks or other
>> identifiers, no?
> 
> Presumably the fallback would go into cs35l41_acpi_get_name()?

That's what I had in mind, if this _SUB does not exist then you could
use something else instead of returning -ENODATA;

+	sub = acpi_get_subsystem_id(handle);
+	if (IS_ERR(sub))
+		return PTR_ERR(sub);
+
+	cs35l41->dsp.system_name = sub;