linux-kernel - Re: [PATCH net-next v2] net/smc: align the connect behaviour with TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcac3b0c-db51-7221-d41a-0207144f131c@linux.ibm.com>
Date:   Thu, 30 Jun 2022 22:16:14 +0200
From:   Wenjia Zhang <wenjia@...ux.ibm.com>
To:     Guangguan Wang <guangguan.wang@...ux.alibaba.com>
Cc:     davem@...emloft.net, Karsten Graul <kgraul@...ux.ibm.com>,
        liuyacan@...p.netease.com, kuba@...nel.org,
        linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        netdev@...r.kernel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next v2] net/smc: align the connect behaviour with TCP



On 30.06.22 16:29, Guangguan Wang wrote:
> I'm so sorry I missed the last emails for this discussion.
> 
> Yes, commit (86434744) is the trigger of the problem described in
> https://lore.kernel.org/linux-s390/45a19f8b-1b64-3459-c28c-aebab4fd8f1e@linux.alibaba.com/#t  .
> 
> And I have tested just remove the following lines from smc_connection() can solve the above problem.
> if (smc->use_fallback)
>       goto out;
> 
> I aggree that partly reverting the commit (86434744) is a better solution.
> 
> Thanks,
> Guangguan Wang
Thank you for your effort!
Would you like to revert this patch? We'll revert the commit (86434744) 
partly.