[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAKwvOdn7o3KFKiaq+Xbjw-RuFfuawZiKSHfzcAAFDHFOKn0zPQ@mail.gmail.com>
Date: Thu, 30 Jun 2022 13:55:50 -0700
From: Nick Desaulniers <ndesaulniers@...gle.com>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org,
Michal Marek <michal.lkml@...kovi.net>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: remove unused cmd_none in scripts/Makefile.modinst
On Thu, Jun 30, 2022 at 1:10 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> Commit 65ce9c38326e ("kbuild: move module strip/compression code into
> scripts/Makefile.modinst") added this unused code.
>
> Perhaps, I thought cmd_none was useful for CONFIG_MODULE_COMPRESS_NONE,
> but I did not use it after all.
LGTM
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
>
> scripts/Makefile.modinst | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
> index c2c43a0ecfe0..16a02e9237d3 100644
> --- a/scripts/Makefile.modinst
> +++ b/scripts/Makefile.modinst
> @@ -28,9 +28,6 @@ modules := $(patsubst $(extmod_prefix)%, $(dst)/%$(suffix-y), $(modules))
> __modinst: $(modules)
> @:
>
> -quiet_cmd_none =
> - cmd_none = :
> -
> #
> # Installation
> #
> --
> 2.32.0
>
--
Thanks,
~Nick Desaulniers
Powered by blists - more mailing lists