linux-kernel - Re: [PATCH v1 RESEND 1/7] dt-bindings: leds: Convert is31fl319x to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dcd817c8a3852f3e6bad0c221a284fb3e69e1ca9.camel@mailoo.org>
Date:   Thu, 30 Jun 2022 23:43:26 +0200
From:   Vincent Knecht <vincent.knecht@...loo.org>
To:     Rob Herring <robh@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
        hns@...delico.com
Subject: Re: [PATCH v1 RESEND 1/7] dt-bindings: leds: Convert is31fl319x to
 dtschema

Le jeudi 30 juin 2022 à 09:28 -0600, Rob Herring a écrit :
> On Tue, Jun 28, 2022 at 08:09:39PM -0600, Rob Herring wrote:
> > On Tue, 28 Jun 2022 20:21:39 +0200, Vincent Knecht wrote:
> > > Convert leds-is31fl319x.txt to dtschema.
> > > Set license to the one recommended by DT project.
> 
> Do you have permission to do so? The original .txt file is default GPL2 
> and owned by H. Nikolaus Schaller. 

No, sorry for the mistake.
Adding to cc, which I forgot to do in the first place...
For reference: https://lore.kernel.org/linux-leds/20220628182147.2837180-1-vincent.knecht@mailoo.org/T/

> > > 
> > > Signed-off-by: Vincent Knecht <vincent.knecht@...loo.org>
> > > ---
> > >  .../bindings/leds/issi,is31fl319x.yaml        | 113 ++++++++++++++++++
> > >  .../bindings/leds/leds-is31fl319x.txt         |  61 ----------
> > >  2 files changed, 113 insertions(+), 61 deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/leds/issi,is31fl319x.yaml
> > >  delete mode 100644 Documentation/devicetree/bindings/leds/leds-is31fl319x.txt
> > > 
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml:
> > patternProperties:^thermistor@:properties:adi,excitation-current-nanoamp: '$ref' should not be valid under {'const':
> > '$ref'}
> >         hint: Standard unit suffix properties don't need a type $ref
> >         from schema $id: http://devicetree.org/meta-schemas/core.yaml#
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: ignoring,
> > error in schema: patternProperties: ^thermistor@: properties: adi,excitation-current-nanoamp
> > Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.example.dtb:0:0: /example-0/spi/ltc2983@0: failed to
> > match any schema with compatible: ['adi,ltc2983']
> 
> You can ignore this. The bot went amuck.
> 

Ack... at least it respected the 3 Laws :-)