linux-kernel - Re: [PATCH] kernfs: fix potential NULL dereference in __kernfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOaDN_Tb9DJhOPXc=r9anoY3pdK3TcjX7Mwg2WQR_GUH66raqQ@mail.gmail.com>
Date:   Thu, 30 Jun 2022 16:12:03 +0800
From:   Katrin Jo <zys.zljxml@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     tj@...nel.org, viro@...iv.linux.org.uk,
        LKML <linux-kernel@...r.kernel.org>,
        katrinzhou <katrinzhou@...cent.com>
Subject: Re: [PATCH] kernfs: fix potential NULL dereference in __kernfs_remove

On Thu, Jun 30, 2022 at 3:28 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Thu, Jun 30, 2022 at 12:00:47PM +0800, zys.zljxml@...il.com wrote:
> > From: katrinzhou <katrinzhou@...cent.com>
> >
> > When lockdep is enabled, lockdep_assert_held_write would
> > cause potential NULL pointer dereference.
> >
> > Fix the folloeing smatch warnings:
> >
> > fs/kernfs/dir.c:1353 __kernfs_remove() warn: variable dereferenced before check 'kn' (see line 1346)
> >
> > Signed-off-by: katrinzhou <katrinzhou@...cent.com>
>
> Can you please submit this with your legal name that you use to sign
> documents?
>
> Also, what commit id does this fix?  Did you actually hit this with a
> real workload?  How can this be reproduced and tested?
>
> thanks,
>
> greg k-h

Sorry for the formatting issue. I'll submit a new patch soon.
This problem is found via static code analysis, and by now
I have not reproduced / tested it.

Best regards,
Katrin