lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Jun 2022 11:27:07 +0300 From: Heikki Krogerus <heikki.krogerus@...ux.intel.com> To: Prashant Malani <pmalani@...omium.org> Cc: linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org, chrome-platform@...ts.linux.dev, bleung@...omium.org, Daisuke Nojiri <dnojiri@...omium.org>, "Dustin L. Howett" <dustin@...ett.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Guenter Roeck <groeck@...omium.org>, "Gustavo A. R. Silva" <gustavoars@...nel.org>, Kees Cook <keescook@...omium.org>, Sebastian Reichel <sebastian.reichel@...labora.com> Subject: Re: [PATCH 2/9] usb: typec: Add retimer handle to port Hi, On Wed, Jun 29, 2022 at 11:32:20PM +0000, Prashant Malani wrote: > Similar to mux and orientation switch, add a handle for registered > retimer to the port, so that it has handles to the various switches > connected to it. > > Signed-off-by: Prashant Malani <pmalani@...omium.org> > --- > drivers/usb/typec/class.c | 8 ++++++++ > drivers/usb/typec/class.h | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c > index 2fa0b3718d23..2bc5fbdb25dd 100644 > --- a/drivers/usb/typec/class.c > +++ b/drivers/usb/typec/class.c > @@ -12,6 +12,7 @@ > #include <linux/slab.h> > #include <linux/usb/pd_vdo.h> > #include <linux/usb/typec_mux.h> > +#include <linux/usb/typec_retimer.h> > > #include "bus.h" > #include "class.h" > @@ -2249,6 +2250,13 @@ struct typec_port *typec_register_port(struct device *parent, > return ERR_PTR(ret); > } > > + port->retimer = typec_retimer_get(&port->dev); > + if (IS_ERR(port->retimer)) { > + ret = PTR_ERR(port->retimer); > + put_device(&port->dev); > + return ERR_PTR(ret); > + } > + > ret = device_add(&port->dev); > if (ret) { > dev_err(parent, "failed to register port (%d)\n", ret); I think you need to release the reference with typec_retimer_put() in typec_release(). I guess we can look handle this later, but there can actually be two onboard retimers for each connector. thanks, > diff --git a/drivers/usb/typec/class.h b/drivers/usb/typec/class.h > index 1bb1da124109..97520406929e 100644 > --- a/drivers/usb/typec/class.h > +++ b/drivers/usb/typec/class.h > @@ -55,6 +55,7 @@ struct typec_port { > enum typec_orientation orientation; > struct typec_switch *sw; > struct typec_mux *mux; > + struct typec_retimer *retimer; > > const struct typec_capability *cap; > const struct typec_operations *ops; -- heikki
Powered by blists - more mailing lists