linux-kernel - Re: [PATCH v2] ACPI: VIOT: Fix ACS setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yr1z2gC0+8zbzpFf@myrica>
Date:   Thu, 30 Jun 2022 10:58:50 +0100
From:   Jean-Philippe Brucker <jean-philippe@...aro.org>
To:     Eric Auger <eric.auger@...hat.com>
Cc:     eric.auger.pro@...il.com, jroedel@...e.de,
        linux-acpi@...r.kernel.org, iommu@...ts.linux-foundation.org,
        rafael@...nel.org, lenb@...nel.org, linux-kernel@...r.kernel.org,
        iommu@...ts.linux.dev, jinl@...hat.com
Subject: Re: [PATCH v2] ACPI: VIOT: Fix ACS setup

On Thu, Jun 30, 2022 at 11:40:59AM +0200, Eric Auger wrote:
> Currently acpi_viot_init() gets called after the pci
> device has been scanned and pci_enable_acs() has been called.
> So pci_request_acs() fails to be taken into account leading
> to wrong single iommu group topologies when dealing with
> multi-function root ports for instance.
> 
> We cannot simply move the acpi_viot_init() earlier, similarly
> as the IORT init because the VIOT parsing relies on the pci
> scan. However we can detect VIOT is present earlier and in
> such a case, request ACS. Introduce a new acpi_viot_early_init()
> routine that allows to call pci_request_acs() before the scan.
> 
> While at it, guard the call to pci_request_acs() with #ifdef
> CONFIG_PCI.
> 
> Fixes: 3cf485540e7b ("ACPI: Add driver for the VIOT table")
> Signed-off-by: Eric Auger <eric.auger@...hat.com>
> Reported-by: Jin Liu <jinl@...hat.com>

Reviewed-by: Jean-Philippe Brucker <jean-philippe@...aro.org>
Tested-by: Jean-Philippe Brucker <jean-philippe@...aro.org>