lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Jun 2022 12:59:49 +0200 From: Philipp Zabel <p.zabel@...gutronix.de> To: Tomer Maimon <tmaimon77@...il.com>, avifishman70@...il.com, tali.perry1@...il.com, joel@....id.au, venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, mturquette@...libre.com, sboyd@...nel.org, gregkh@...uxfoundation.org, daniel.lezcano@...aro.org, tglx@...utronix.de, wim@...ux-watchdog.org, linux@...ck-us.net, catalin.marinas@....com, will@...nel.org, arnd@...db.de, olof@...om.net, jirislaby@...nel.org, shawnguo@...nel.org, bjorn.andersson@...aro.org, geert+renesas@...der.be, marcel.ziswiler@...adex.com, vkoul@...nel.org, biju.das.jz@...renesas.com, nobuhiro1.iwamatsu@...hiba.co.jp, robert.hancock@...ian.com, j.neuschaefer@....net, lkundrak@...sk Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, linux-serial@...r.kernel.org, linux-watchdog@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v6 08/17] reset: npcm: using syscon instead of device data Hi Tomer, On Do, 2022-06-30 at 13:35 +0300, Tomer Maimon wrote: Using syscon device tree property instead of device data to handle the NPCM general control registers. In case the syscon not found the code still search for nuvoton,npcm750-gcr to support DTS backward compatibility. Signed-off-by: Tomer Maimon <tmaimon77@...il.com> --- drivers/reset/reset-npcm.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/reset/reset-npcm.c b/drivers/reset/reset-npcm.c index 2ea4d3136e15..431ff2b602c5 100644 --- a/drivers/reset/reset-npcm.c +++ b/drivers/reset/reset-npcm.c @@ -138,8 +138,7 @@ static int npcm_reset_xlate(struct reset_controller_dev *rcdev, } static const struct of_device_id npcm_rc_match[] = { - { .compatible = "nuvoton,npcm750-reset", - .data = (void *)"nuvoton,npcm750-gcr" }, + { .compatible = "nuvoton,npcm750-reset"}, Add a space. ^^ { } }; @@ -155,15 +154,15 @@ static int npcm_usb_reset(struct platform_device *pdev, struct npcm_rc_data *rc) u32 ipsrst1_bits = 0; u32 ipsrst2_bits = NPCM_IPSRST2_USB_HOST; u32 ipsrst3_bits = 0; - const char *gcr_dt; - gcr_dt = (const char *) - of_match_device(dev->driver->of_match_table, dev)->data; - - gcr_regmap = syscon_regmap_lookup_by_compatible(gcr_dt); + gcr_regmap = syscon_regmap_lookup_by_phandle(dev->of_node, "nuvoton,sysgcr"); if (IS_ERR(gcr_regmap)) { - dev_err(&pdev->dev, "Failed to find %s\n", gcr_dt); - return PTR_ERR(gcr_regmap); + dev_warn(&pdev->dev, "Failed to find nuvoton,sysgcr search for nuvoton,npcm750-gcr for Poleg backward compatibility"); Is this warning useful to the user? Maybe add suggestion like "please update the device tree". Also there is no further message if nuvoton,npcm750-gcr is found and all is well. regards Philipp
Powered by blists - more mailing lists