linux-kernel - Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220630115848.hkzavd67cwjubjq4@viti.kaiser.cx>
Date:   Thu, 30 Jun 2022 13:58:49 +0200
From:   Martin Kaiser <lists@...ser.cx>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        paskripkin@...il.com, gregkh@...uxfoundation.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] staging: r8188eu: remove unneeded semicolon

Thus wrote Yang Li (yang.lee@...ux.alibaba.com):

> Eliminate the following coccicheck warning:
> ./drivers/staging/r8188eu/hal/HalPwrSeqCmd.c:70:2-3: Unneeded semicolon

> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> index b5f6d41464db..5b0f66573d94 100644
> --- a/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> +++ b/drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
> @@ -67,7 +67,7 @@ u8 HalPwrSeqCmdParsing(struct adapter *padapter, enum r8188eu_pwr_seq seq)
>  		break;
>  	default:
>  		return false;
> -	};
> +	}

>  	do {
>  		pwrcfgcmd = pwrseqcmd[aryidx];
> -- 
> 2.20.1.7.g153144c

Thanks for spotting this.

Fixes: df8d0a55047b ("staging: r8188eu: make power sequences static")
Reviewed-by: Martin Kaiser <martin@...ser.cx>