linux-kernel - Re: [PATCH] irqchip/xilinx: add explicit dependency on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d51b5494-66db-69a8-cd34-40d33f4f212b@amd.com>
Date:   Thu, 30 Jun 2022 14:33:25 +0200
From:   Michal Simek <michal.simek@....com>
To:     Jamie Iles <jamie@...ieiles.com>, <maz@...nel.org>
CC:     <linux-kernel@...r.kernel.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] irqchip/xilinx: add explicit dependency on OF_ADDRESS



On 6/30/22 13:10, Jamie Iles wrote:
> Commit b84dc7f0e364 ("irqchip/xilinx: Remove microblaze+zynq
> dependency") relaxed the dependencies on the Xilinx interrupt controller
> to be OF only, but some OF architectures (s390 for example) do not
> support OF_ADDRESS and so a build of the driver will result in undefined
> references to of_iomap/iounmap and friends.
> 

Can you please add here fixed tag?

> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Jamie Iles <jamie@...ieiles.com>
> ---
>   drivers/irqchip/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 1f23a6be7d88..bbb11cb8b0f7 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -298,7 +298,7 @@ config XTENSA_MX
>   
>   config XILINX_INTC
>   	bool "Xilinx Interrupt Controller IP"
> -	depends on OF
> +	depends on OF_ADDRESS
>   	select IRQ_DOMAIN
>   	help
>   	  Support for the Xilinx Interrupt Controller IP core.

When above added feel free to add my
Acked-by: Michal Simek <michal.simek@....com>

Thanks,
Michal