linux-kernel - Re: [PATCH] io_uring: fix a typo in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <FA9C6A6C-C02F-4CEE-A423-E4A7BBA61C23@gmail.com>
Date:   Thu, 30 Jun 2022 10:28:55 +0800
From:   Xinghui Li <korantwork@...il.com>
To:     Jens Axboe <axboe@...nel.dk>, <asml.silence@...il.com>
CC:     <io-uring@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Xinghui Li <korantli@...cent.com>
Subject: Re: [PATCH] io_uring: fix a typo in comment

On 2022/6/29 22:46，“Jens Axboe”<axboe@...nel.dk> wrote:
>
>    On 6/29/22 8:43 AM, korantwork@...il.com wrote:
>    > From: Xinghui Li <korantli@...cent.com>
>    > 
>    > fix a typo in comment in io_allocate_scq_urings.
>    > sane -> same.
>    > 
>    > Signed-off-by: Xinghui Li <korantli@...cent.com>
>    > ---
>    >  fs/io_uring.c | 2 +-
>    >  1 file changed, 1 insertion(+), 1 deletion(-)
>    > 
>    > diff --git a/fs/io_uring.c b/fs/io_uring.c
>    > index d3ee4fc532fa..af17adf3fa79 100644
>    > --- a/fs/io_uring.c
>    > +++ b/fs/io_uring.c
>    > @@ -12284,7 +12284,7 @@ static __cold int io_allocate_scq_urings(struct io_ring_ctx *ctx,
>    >  	struct io_rings *rings;
>    >  	size_t size, sq_array_offset;
>    >  
>    > -	/* make sure these are sane, as we already accounted them */
>    > +	/* make sure these are same, as we already accounted them */
>    >  	ctx->sq_entries = p->sq_entries;
>    >  	ctx->cq_entries = p->cq_entries;

>    That's not really a typo, though I can see why you'd think so. It's
>    trying to say that we need to ensure that the ctx entries are sane,
>    as they have already been accounted. This means that if we teardown
>    past this point, they need to be assigned (eg sane) so that we undo
>    that accounting appropriately.

Thanks a lot for your reply and I am sorry about wasting your effort. I will try to submit some valuable patches. : - )

-- 
Xinghui Li