linux-kernel - Re: [PATCH v3 13/16] pinctrl: Add AXP192 pin control driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <HVuKY4uz71KVTEQCbjewrX6SufiowzOP@localhost>
Date:   Fri, 01 Jul 2022 16:51:59 +0100
From:   Aidan MacDonald <aidanmacdonald.0x0@...il.com>
To:     Michael Walle <michael@...le.cc>
Cc:     linus.walleij@...aro.org, brgl@...ev.pl, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, wens@...e.org, jic23@...nel.org,
        lee.jones@...aro.org, sre@...nel.org, broonie@...nel.org,
        gregkh@...uxfoundation.org, lgirdwood@...il.com, lars@...afoo.de,
        rafael@...nel.org, quic_gurus@...cinc.com,
        sebastian.reichel@...labora.com, andy.shevchenko@...il.com,
        linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 13/16] pinctrl: Add AXP192 pin control driver


Michael Walle <michael@...le.cc> writes:

> Am 2022-06-27 15:12, schrieb Aidan MacDonald:
>
>>> I *think* what is needed for gpio-regmap to support this is:
>>>  - support values and masks for the direction, for now, we
>>>    only support single bits.
>>>  - support the pinctrl_gpio_direction_{input,output} calls
>>> -michael
>> That sounds about right, thanks for taking a look.
>
> I thought you were trying to add these to gpio-regmap? Unless
> I'm missing something, that should be easy enough.
>
> -michael

Yeah, I can send patches this weekend. One detail I missed was the
to_irq() part, so I'm going to add a hook for that too.

The alternative is using hierarchical IRQ domains, but that seems
like a lot of added complication when to_irq() works just as well.