linux-kernel - Re: [PATCH] iio: adc: ti-tsc2046: do not explicity set INDIO_BUFFER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 1 Jul 2022 17:50:55 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Marcus Folkesson <marcus.folkesson@...il.com>,
        Oleksij Rempel <linux@...pel-privat.de>, kernel@...gutronix.de,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ti-tsc2046: do not explicity set
 INDIO_BUFFER_TRIGGERED mode

On Thu, 30 Jun 2022 07:07:26 +0200
Oleksij Rempel <o.rempel@...gutronix.de> wrote:

> On Wed, Jun 29, 2022 at 10:39:10PM +0200, Marcus Folkesson wrote:
> > The core sets INDIO_BUFFER_TRIGGERED as part of
> > devm_iio_triggered_buffer_setup().
> > 
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>  
> 
> Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>
> 
Applied,

Thanks,

Jonathan

> Thank you!
> 
> > ---
> >  drivers/iio/adc/ti-tsc2046.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/ti-tsc2046.c b/drivers/iio/adc/ti-tsc2046.c
> > index 55b35570ad8b..0d9436a69cbf 100644
> > --- a/drivers/iio/adc/ti-tsc2046.c
> > +++ b/drivers/iio/adc/ti-tsc2046.c
> > @@ -776,7 +776,7 @@ static int tsc2046_adc_probe(struct spi_device *spi)
> >  	priv->spi = spi;
> >  
> >  	indio_dev->name = TI_TSC2046_NAME;
> > -	indio_dev->modes = INDIO_DIRECT_MODE | INDIO_BUFFER_TRIGGERED;
> > +	indio_dev->modes = INDIO_DIRECT_MODE;
> >  	indio_dev->channels = dcfg->channels;
> >  	indio_dev->num_channels = dcfg->num_channels;
> >  	indio_dev->info = &tsc2046_adc_info;
> > -- 
> > 2.36.1
> > 
> > 
> >   
>