linux-kernel - Re: [PATCH v2 4/6] leds: is31fl319x: Use non-wildcard names for vars, structs and defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdpQ5J1nSONpM=C9YL1Qd6sJMLbrmGT_3uQHn8Um_0++w@mail.gmail.com>
Date:   Fri, 1 Jul 2022 22:49:08 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Vincent Knecht <vincent.knecht@...loo.org>
Cc:     Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        "H. Nikolaus Schaller" <hns@...delico.com>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org
Subject: Re: [PATCH v2 4/6] leds: is31fl319x: Use non-wildcard names for vars,
 structs and defines

On Fri, Jul 1, 2022 at 10:47 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Fri, Jul 1, 2022 at 3:45 PM Vincent Knecht <vincent.knecht@...loo.org> wrote:

...

> > +#define IS31FL3196_CURRENT_MIN         ((u32)5000)
> > +#define IS31FL3196_CURRENT_MAX         ((u32)40000)
> > +#define IS31FL3196_CURRENT_STEP                ((u32)5000)
> > +#define IS31FL3196_CURRENT_DEFAULT     ((u32)20000)

Also why no units as below, for example, has?

> > +#define IS31FL3196_AUDIO_GAIN_DB_MAX   ((u32)21)
> > +#define IS31FL3196_AUDIO_GAIN_DB_STEP  ((u32)3)

-- 
With Best Regards,
Andy Shevchenko