| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202207020526.2D6gM7Xj-lkp@intel.com>
Date: Sat, 2 Jul 2022 05:30:22 +0800
From: kernel test robot <lkp@...el.com>
To: David Howells <dhowells@...hat.com>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:dhowells/linux-fs/netfs-linked-list 46/61]
fs/netfs/buffered_flush.c:434:16: warning: comparison of distinct pointer
types ('typeof (hard_align) *' (aka 'unsigned int *') and 'typeof ((1UL <<
18) << ctx->cache_order) *' (aka 'unsigned long *'))
tree: https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/netfs-linked-list
head: ce4670495468b797b0c5927fcb661bc0da48b9ab
commit: 2dc27084e13c29183f0a6853b81e5fa2941948e3 [46/61] netfs: Generate a write request from ->writepages()
config: hexagon-randconfig-r034-20220629 (https://download.01.org/0day-ci/archive/20220702/202207020526.2D6gM7Xj-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project a9119143a2d1f4d0d0bc1fe0d819e5351b4e0deb)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/2dc27084e13c29183f0a6853b81e5fa2941948e3
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block dhowells/linux-fs/netfs-linked-list
git checkout 2dc27084e13c29183f0a6853b81e5fa2941948e3
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/netfs/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
fs/netfs/buffered_flush.c:431:16: warning: comparison of distinct pointer types ('typeof (hard_align) *' (aka 'unsigned int *') and 'typeof (1UL << __builtin_choose_expr(((!!(sizeof ((typeof (ctx->min_bshift) *)1 == (typeof (ctx->crypto_bshift) *)1))) && ((sizeof(int) == sizeof (*(8 ? ((void *)((long)(ctx->min_bshift) * 0L)) : (int *)8))) && (sizeof(int) == sizeof (*(8 ? ((void *)((long)(ctx->crypto_bshift) * 0L)) : (int *)8))))), ((ctx->min_bshift) > (ctx->crypto_bshift) ? (ctx->min_bshift) : (ctx->crypto_bshift)), ({
typeof (ctx->min_bshift) __UNIQUE_ID___x256 = (ctx->min_bshift);
typeof (ctx->crypto_bshift) __UNIQUE_ID___y257 = (ctx->crypto_bshift);
((__UNIQUE_ID___x256) > (__UNIQUE_ID___y257) ? (__UNIQUE_ID___x256) : (__UNIQUE_ID___y257));
}))) *' (aka 'unsigned long *')) [-Wcompare-distinct-pointer-types]
hard_align = max(hard_align,
^~~~~~~~~~~~~~~
include/linux/minmax.h:52:19: note: expanded from macro 'max'
#define max(x, y) __careful_cmp(x, y, >)
^~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~~~~~~~
include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~~~~~~~
include/linux/minmax.h:20:28: note: expanded from macro '__typecheck'
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
>> fs/netfs/buffered_flush.c:434:16: warning: comparison of distinct pointer types ('typeof (hard_align) *' (aka 'unsigned int *') and 'typeof ((1UL << 18) << ctx->cache_order) *' (aka 'unsigned long *')) [-Wcompare-distinct-pointer-types]
hard_align = max(hard_align, PAGE_SIZE << ctx->cache_order);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:52:19: note: expanded from macro 'max'
#define max(x, y) __careful_cmp(x, y, >)
^~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~~~~~~~
include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~~~~~~~
include/linux/minmax.h:20:28: note: expanded from macro '__typecheck'
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
>> fs/netfs/buffered_flush.c:436:10: warning: comparison of distinct pointer types ('typeof (hard_align) *' (aka 'unsigned int *') and 'typeof ((1UL << (0 ? 4 : 6)) * (1UL << 18)) *' (aka 'unsigned long *')) [-Wcompare-distinct-pointer-types]
align = min(hard_align, XA_CHUNK_SIZE * PAGE_SIZE);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:45:19: note: expanded from macro 'min'
#define min(x, y) __careful_cmp(x, y, <)
^~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~~~~~~~
include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~~~~~~~
include/linux/minmax.h:20:28: note: expanded from macro '__typecheck'
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
fs/netfs/buffered_flush.c:556:22: warning: format specifies type 'size_t' (aka 'unsigned int') but the argument has type 'unsigned long' [-Wformat]
_leave(" ok [%zx]", wreq->last);
~~~ ^~~~~~~~~~
%lx
fs/netfs/internal.h:301:65: note: expanded from macro '_leave'
#define _leave(FMT, ...) no_printk("<== %s()"FMT"", __func__, ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/printk.h:131:17: note: expanded from macro 'no_printk'
printk(fmt, ##__VA_ARGS__); \
~~~ ^~~~~~~~~~~
include/linux/printk.h:464:60: note: expanded from macro 'printk'
#define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/printk.h:436:19: note: expanded from macro 'printk_index_wrap'
_p_func(_fmt, ##__VA_ARGS__); \
~~~~ ^~~~~~~~~~~
fs/netfs/buffered_flush.c:568:26: warning: format specifies type 'size_t' (aka 'unsigned int') but the argument has type 'unsigned long' [-Wformat]
_leave(" cancel [%zx]", wreq->last);
~~~ ^~~~~~~~~~
%lx
fs/netfs/internal.h:301:65: note: expanded from macro '_leave'
#define _leave(FMT, ...) no_printk("<== %s()"FMT"", __func__, ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/printk.h:131:17: note: expanded from macro 'no_printk'
printk(fmt, ##__VA_ARGS__); \
~~~ ^~~~~~~~~~~
include/linux/printk.h:464:60: note: expanded from macro 'printk'
#define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/printk.h:436:19: note: expanded from macro 'printk_index_wrap'
_p_func(_fmt, ##__VA_ARGS__); \
~~~~ ^~~~~~~~~~~
fs/netfs/buffered_flush.c:371:33: warning: unused function 'netfs_find_writeback' [-Wunused-function]
static struct netfs_io_request *netfs_find_writeback(struct netfs_inode *ctx,
^
fs/netfs/buffered_flush.c:387:13: warning: unused function 'netfs_wait_for_writeback' [-Wunused-function]
static void netfs_wait_for_writeback(struct netfs_io_request *wreq,
^
7 warnings generated.
vim +434 fs/netfs/buffered_flush.c
395
396 /*
397 * Extend the region to be written back to include subsequent contiguously
398 * dirty pages if possible, but don't sleep while doing so.
399 *
400 * If this page holds new content, then we can include filler zeros in the
401 * writeback.
402 */
403 static void netfs_extend_writeback(struct netfs_io_request *wreq,
404 struct writeback_control *wbc,
405 struct netfs_inode *ctx,
406 struct netfs_dirty_region *region)
407 {
408 struct folio_batch fbatch;
409 struct folio *folio;
410 unsigned int i;
411 pgoff_t index = wreq->last + 1, stop_mask, stop_at, max_pages;
412 ssize_t max_size;
413 size_t align, hard_align;
414 bool stop = true, dirty;
415 int ret;
416
417 XA_STATE(xas, &wreq->mapping->i_pages, index);
418
419 _enter("%lx", index);
420
421 /* We have a number of criteria by which we can decide where to stop
422 * extension of this writeback:
423 *
424 * 1) The maximum I/O size (but wbacks can be subdivided)
425 * 2) Boundaries within the filesystem (eg. ceph object size)
426 * 3) Local boundaries (cache granules, VM radix node sizes)
427 * 4) Content crypto/compression boundaries
428 */
429 hard_align = PAGE_SIZE;
430 if (ctx->min_bshift || ctx->crypto_bshift)
431 hard_align = max(hard_align,
432 1UL << max(ctx->min_bshift, ctx->crypto_bshift));
433 if (ctx->cache_order)
> 434 hard_align = max(hard_align, PAGE_SIZE << ctx->cache_order);
435
> 436 align = min(hard_align, XA_CHUNK_SIZE * PAGE_SIZE);
437 if (wreq->alignment > align)
438 align = wreq->alignment;
439
440 stop_mask = (align - 1) / PAGE_SIZE;
441
442 max_size = XA_CHUNK_SIZE * PAGE_SIZE;
443 if (wreq->wsize > max_size)
444 max_size = roundup_pow_of_two(wreq->wsize);
445
446 _debug("LIMITS al=%zx ha=%zx mx=%zx", align, hard_align, max_size);
447
448 max_pages = max_size / PAGE_SIZE;
449 max_pages &= ~stop_mask;
450 _debug("MAX_PAGES %lx %lx", max_pages, stop_mask);
451 if (wreq->last - wreq->first + 1 >= max_pages) {
452 _leave(" [already hit wsize %lx %lx]",
453 wreq->last - wreq->first + 1, max_pages);
454 return;
455 }
456
457 stop_at = wreq->first + max_pages;
458 if (stop_at < wreq->first)
459 stop_at = ULONG_MAX;
460 else
461 stop_at = round_down(stop_at, align / PAGE_SIZE);
462 _debug("STOP_AT %lx (%lx %lx %lx)", stop_at, wreq->first, max_pages, align / PAGE_SIZE);
463
464 if (index >= stop_at || wbc->nr_to_write <= 0 || wreq->len > max_size) {
465 _leave(" [prestop]");
466 return;
467 }
468
469 do {
470 /* Firstly, we gather up a batch of contiguous dirty folios
471 * under the RCU read lock - but we can't clear the dirty flags
472 * there if any of those folios are mapped.
473 */
474 folio_batch_init(&fbatch);
475 _debug("extend %lx %lx", index, xas.xa_index);
476 rcu_read_lock();
477
478 xas_for_each(&xas, folio, ULONG_MAX) {
479 stop = true;
480 if (xas_retry(&xas, folio))
481 continue;
482 if (xa_is_value(folio))
483 break;
484 if (folio_index(folio) != index)
485 break;
486
487 if (!folio_try_get_rcu(folio)) {
488 xas_reset(&xas);
489 continue;
490 }
491
492 /* Has the folio moved or been split? */
493 if (unlikely(folio != xas_reload(&xas))) {
494 folio_put(folio);
495 break;
496 }
497
498 if (!folio_trylock(folio)) {
499 folio_put(folio);
500 break;
501 }
502 if (!folio_test_dirty(folio) ||
503 folio_test_writeback(folio)) {
504 folio_unlock(folio);
505 folio_put(folio);
506 break;
507 }
508
509 wreq->len += folio_size(folio);
510 index += folio_nr_pages(folio);
511 stop = index >= stop_at || wbc->nr_to_write <= 0;
512
513 if (!folio_batch_add(&fbatch, folio))
514 break;
515 if (stop)
516 break;
517 }
518
519 if (!stop)
520 xas_pause(&xas);
521 rcu_read_unlock();
522
523 /* Now, if we obtained any pages, we can shift them to being
524 * writable and mark them for caching.
525 */
526 if (!folio_batch_count(&fbatch))
527 break;
528
529 for (i = 0; i < folio_batch_count(&fbatch); i++) {
530 folio = fbatch.folios[i];
531 //_debug("found [%x] %lx", i, folio->index);
532 trace_netfs_folio_dirty(wreq->mapping, folio,
533 netfs_folio_trace_store_ex);
534
535 dirty = folio_clear_dirty_for_io(folio);
536 if (folio_start_writeback(folio)) {
537 _debug("! no wb");
538 goto nomem_redirty;
539 }
540
541 ret = netfs_xa_store_and_mark(&wreq->buffer, folio->index, folio,
542 true, true, dirty, GFP_NOFS);
543 if (ret < 0) {
544 _debug("! no buffer");
545 goto nomem_cancel_wb;
546 }
547 wbc->nr_to_write -= folio_nr_pages(folio);
548 index = folio_next_index(folio);
549 wreq->last = index - 1;
550 folio_unlock(folio);
551 }
552
553 cond_resched();
554 } while (!stop);
555
556 _leave(" ok [%zx]", wreq->last);
557 return;
558
559 nomem_cancel_wb:
560 folio_end_writeback(folio);
561 nomem_redirty:
562 if (dirty)
563 folio_redirty_for_writepage(wbc, folio);
564 for (; i < folio_batch_count(&fbatch); i++) {
565 folio_unlock(folio);
566 folio_put(folio);
567 }
568 _leave(" cancel [%zx]", wreq->last);
569 }
570
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists