[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220701220402.v4g6u75mzptb2fly@notapiano>
Date: Fri, 1 Jul 2022 18:04:02 -0400
From: NĂcolas F. R. A. Prado
<nfraprado@...labora.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
Cc: robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
matthias.bgg@...il.com, hsinyi@...omium.org,
allen-kh.cheng@...iatek.com, gtk3@...ox.ru, luca@...tu.xyz,
sam.shih@...iatek.com, sean.wang@...iatek.com,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, wenst@...omium.org
Subject: Re: [PATCH 01/11] dt-bindings: arm: mediatek: Add MT8195 Cherry
Tomato Chromebooks
On Thu, Jun 30, 2022 at 05:33:06PM +0200, AngeloGioacchino Del Regno wrote:
> Document board compatibles for the MT8195 Cherry platform's
> Tomato Chromebooks, at the time of writing composed of four
> revisions (r0, r1, r2, r3-r4).
Though r0 is not added in this series?
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index dd6c6e8011f9..3e0afa17ed2e 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -144,6 +144,19 @@ properties:
> - const: google,spherion-rev0
> - const: google,spherion
> - const: mediatek,mt8192
Angelo, this patch is depending on the patch from the asurada-spherion series
[1] to apply. Since this isn't the case for patch 2 as well, I assume this was
a mistake. And it does seem better to keep them independent.
[1] https://lore.kernel.org/all/20220629155956.1138955-2-nfraprado@collabora.com/
Thanks,
NĂcolas
> + - description: Google Tomato (Acer Chromebook Spin 513)
> + items:
> + - enum:
> + - google,tomato-rev2
> + - google,tomato-rev1
> + - const: google,tomato
> + - const: mediatek,mt8195
> + - description: Google Tomato (rev3 - 4)
> + items:
> + - const: google,tomato-rev4
> + - const: google,tomato-rev3
> + - const: google,tomato
> + - const: mediatek,mt8195
> - items:
> - enum:
> - mediatek,mt8186-evb
> --
> 2.35.1
>
Powered by blists - more mailing lists