linux-kernel - Re: [PATCH v2 2/2] module: Increase readability of module_kallsyms_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yr9wEiJpu6EfPdaq@bombadil.infradead.org>
Date:   Fri, 1 Jul 2022 15:07:14 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Christophe Leroy <christophe.leroy@...roup.eu>
Cc:     linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] module: Increase readability of
 module_kallsyms_lookup_name()

On Mon, Jun 13, 2022 at 08:02:02AM +0200, Christophe Leroy wrote:
> module_kallsyms_lookup_name() has several exit conditions but
> can't return immediately due to preempt_disable().
> 
> Refactor module_kallsyms_lookup_name() to allow returning from
> anywhere, and reduce depth.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>

Thanks for this cleanup, holy crap that was gross before, queued up!

  Luis