linux-kernel - Re: [PATCH 1/2] perf tools: Don't sort the task scan result from /proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fVbp4QT2J4Ek9e+1XL1HEMrUrYgNXptcWqyCHZxWbVAGA@mail.gmail.com>
Date:   Fri, 1 Jul 2022 16:06:05 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/2] perf tools: Don't sort the task scan result from /proc

On Fri, Jul 1, 2022 at 1:55 PM Namhyung Kim <namhyung@...nel.org> wrote:
>
> It should not sort the result as procfs already returns a proper
> ordering of tasks.  Actually sorting the order caused problems that it
> doesn't guararantee to process the main thread first.
>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

Acked-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/util/synthetic-events.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/synthetic-events.c b/tools/perf/util/synthetic-events.c
> index 27acdc5e5723..a068f42833c3 100644
> --- a/tools/perf/util/synthetic-events.c
> +++ b/tools/perf/util/synthetic-events.c
> @@ -754,7 +754,7 @@ static int __event__synthesize_thread(union perf_event *comm_event,
>         snprintf(filename, sizeof(filename), "%s/proc/%d/task",
>                  machine->root_dir, pid);
>
> -       n = scandir(filename, &dirent, filter_task, alphasort);
> +       n = scandir(filename, &dirent, filter_task, NULL);
>         if (n < 0)
>                 return n;
>
> @@ -987,7 +987,7 @@ int perf_event__synthesize_threads(struct perf_tool *tool,
>                 return 0;
>
>         snprintf(proc_path, sizeof(proc_path), "%s/proc", machine->root_dir);
> -       n = scandir(proc_path, &dirent, filter_task, alphasort);
> +       n = scandir(proc_path, &dirent, filter_task, NULL);
>         if (n < 0)
>                 return err;
>
> --
> 2.37.0.rc0.161.g10f37bed90-goog
>